New issue
Advanced search Search tips

Issue 827994 link

Starred by 1 user
Status: Duplicate
Merged: issue 830507
Owner:
v8-autoroll@chromium.org
Closed: May 2018
Cc:
mlippautz@chromium.org
yangguo@chromium.org
leszeks@chromium.org
jgruber@chromium.org
ahaas@chromium.org
v8-autoroll@chromium.org
mstarzinger@chromium.org
clemensh@chromium.org
u...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.9%-9.5% regression in system_health.memory_mobile at 545137:545243

Project Member Reported by ulan@google.com, Apr 2 2018 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Apr 2 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=827994

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=3229ef44d7db2e1607fac2a5be10d0cb0ef9b2e69e601c9fce6889ddf03bcdc4


Bot(s) for this bug's original alert(s):

android-nexus5X
android-nexus6
android-nexus7v2
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Apr 3 2018

Cc: mstarzinger@chromium.org yangguo@chromium.org jgruber@chromium.org mlippautz@chromium.org ahaas@chromium.org leszeks@chromium.org clemensh@chromium.org v8-autoroll@chromium.org
Owner: v8-autoroll@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 4 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/16bdd2ef440000

Reland: Remove SFI code field by leszeks@chromium.org
https://chromium.googlesource.com/v8/v8/+/d8f564eac6152c05f6521572b6f06146c2e99eb1

[fuzzer] Slightly improve generated test cases by clemensh@chromium.org
https://chromium.googlesource.com/v8/v8/+/9beac3838d2bb93fc3618cea831e00d2b0cbb674

Reland "[builtins] Load external references from the external-reference-table" by jgruber@chromium.org
https://chromium.googlesource.com/v8/v8/+/0031724fd02b3d992d04f54d02ca4e4ad0550af8

Update V8 to version 6.7.142. by v8-autoroll@chromium.org
https://chromium.googlesource.com/chromium/src/+/a48f241bc00414b325b0b682ca6d38028c422299

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by clemensh@chromium.org, Apr 3 2018

Cc: -clemensh@chromium.org

Comment 5 by jgruber@chromium.org, Apr 4 2018

Owner: leszeks@chromium.org
From pinpoint results the culprit CL isn't clear, suspecting 

Reland: Remove SFI code field by leszeks@chromium.org
https://chromium.googlesource.com/v8/v8/+/d8f564eac6152c05f6521572b6f06146c2e99eb1


Although that CL, AFAIK, should reduce memory usage. Leszek could you take a look, does this seem plausible?
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Apr 4 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14d28a70c40000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Apr 4 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14cf8230c40000

Comment 10 by leszeks@chromium.org, Apr 4 2018 

Meanwhile, this looks like an old-space size increase. Could it be caused by builtin size increase?

Comment 11 by jgruber@chromium.org, Apr 4 2018 

Don't think so, builtins would show in either CODE or LOSPACE.

Comment 12 by leszeks@chromium.org, Apr 4 2018 

Well, seems unlikely to be the SFI stuff then I think, the only old-space changes *should* (famous last words) be positive. Sadly, seems pinpoint is misbehaving...
Project Member

Comment 15 by 42576172...@developer.gserviceaccount.com, Apr 9 2018

Cc: clemensh@chromium.org
Owner: v8-autoroll@chromium.org
📍 Found significant differences after each of 4 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/149619d4c40000

Reland: Remove SFI code field by leszeks@chromium.org
https://chromium.googlesource.com/v8/v8/+/d8f564eac6152c05f6521572b6f06146c2e99eb1

[fuzzer] Slightly improve generated test cases by clemensh@chromium.org
https://chromium.googlesource.com/v8/v8/+/9beac3838d2bb93fc3618cea831e00d2b0cbb674

Reland "[builtins] Load external references from the external-reference-table" by jgruber@chromium.org
https://chromium.googlesource.com/v8/v8/+/0031724fd02b3d992d04f54d02ca4e4ad0550af8

Update V8 to version 6.7.142. by v8-autoroll@chromium.org
https://chromium.googlesource.com/chromium/src/+/a48f241bc00414b325b0b682ca6d38028c422299

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 16 by clemensh@chromium.org, Apr 9 2018

Cc: -clemensh@chromium.org
Still not mine :)

Comment 18 by leszeks@chromium.org, May 1 2018

Mergedinto: 830507
Status: Duplicate (was: Assigned)
Considering this a dupe, assuming that it's bad luck with GC.
►

Sign in to add a comment