New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827971 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 828000
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1%-6.7% regression in system_health.memory_mobile at 546420:546589

Project Member Reported by ulan@google.com, Apr 2 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=827971

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4da1cbeafa37eaee04e9e8d6609de51dc9a922d4eda7c6e4d01ea2fd45683136


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-webview-nexus5X
android-webview-nexus6
linux-release
win-high-dpi

Comment 3 by u...@chromium.org, Apr 2 2018

Cc: -u...@chromium.com u...@chromium.org
Cc: tommycli@chromium.org joelhockey@chromium.org pbos@chromium.org
Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/1294993f440000

Add deps for ui/file_manager/file_manager/test:create_test_main. by joelhockey@chromium.org
https://chromium.googlesource.com/chromium/src/+/7d5277c33bb3d019267dae02294fd7995c981201

Revert "Remove separator from rounded omnibox results" by pbos@chromium.org
https://chromium.googlesource.com/chromium/src/+/69dba8579e293f519384ec12685a628033f9a83d

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 5 by pbos@chromium.org, Apr 4 2018

Owner: ----
Status: Untriaged (was: Assigned)
I don't see either of these as related. joelhockey@ touches a test-only target and my change is not compiled into Android and the flag that enables the code isn't on by default on desktop either.
Cc: mtomasz@chromium.org allenvic@chromium.org v8-autoroll@chromium.org fukino@chromium.org noel@chromium.org
Owner: v8-autoroll@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14e542e0c40000

[FSP] Do not get watchers for unwatchable file systems by allenvic@chromium.org
https://chromium.googlesource.com/chromium/src/+/67af16ed4b5c8dcca09f8b6dd0d892c4e9e57c93

Update V8 to version 6.7.194. by v8-autoroll@chromium.org
https://chromium.googlesource.com/chromium/src/+/cebfc209d737ca36c02775eb86f306cbe556ae69

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 8 by noel@chromium.org, Apr 5 2018

Seems pin-point is having issues identifying the culprit.  There is a row of crashed builds to https://pinpoint-dot-chromeperf.appspot.com/job/14e542e0c40000, 8 CL in all, [FSP] Do not get watchers for unwatchable file systems" is the first that happens to build, and is blamed.


Cc: mathias@chromium.org neis@chromium.org adamk@chromium.org jkummerow@chromium.org
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12fc8288c40000

Ship BigInts by jkummerow@chromium.org
https://chromium.googlesource.com/v8/v8/+/16aecc5d9b091486994b1a4aa756294e5c535ee3

Update V8 to version 6.7.194. by v8-autoroll@chromium.org
https://chromium.googlesource.com/chromium/src/+/cebfc209d737ca36c02775eb86f306cbe556ae69

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 12 by pbos@chromium.org, Apr 5 2018

Cc: jgruber@chromium.org
Owner: jgruber@chromium.org
Shot in the dark, but jgruber, would b2f0d8617b9bb8aa463f6d8b7f8ca99b6ab285de disabling embedded built-ins explain a 4% increase in memory usage?

Assigning to you because I think the autoroller is probably a terrible assignee? Feel free to unassign (if you can't triage) and kick off another bisect job unless someone else steps up.
Mergedinto: 828000
Owner: jgruber@chromium.org
Status: Duplicate (was: Assigned)
Yep, this looks like my embedded builtins revert, which will hopefully be relanded permanently after the branch cut. Thanks for triaging! 

Sign in to add a comment