Regression : 'Gmail', 'Images' links on NTP are not clickable for the first instance.
Reported by
avsha...@etouch.net,
Apr 2 2018
|
||||||||
Issue descriptionChrome Version : 67.0.3386.0 (Official Build) 83a2c341a3999a32a01e268bdb891a56d6edd548-refs/heads/master@{#547395} 32/64-bit OS : Windows(7,8,8.1,10), Linux(14.04 LTS), Mac(10.12.6, 10.13.4) What steps will reproduce the problem? 1. Install a fresh copy of chrome and launch it. 2. Click on Avatar icon, go to 'Manage People' and add a new person. (chrome://welcome page appears in newly added person) 3. Hit Ctrl + T to open a NTP and try to click on 'Gmail', 'Images' links shown in top right corner on NTP. 4. Observe. Actual Result : 'Gmail', 'Images' links on NTP are not clickable for the first instance. Expected Result : 'Gmail', 'Images' links on NTP should always be clickable. This is a regression issue, broken in M-67 and providing the bisect using per-revision script: Good Build : 67.0.3382.0 (Revision : 546347) Bad Build : 67.0.3383.0 (Revision : 546671) You are probably looking for a change made after 546576 (known good), but no later than 546577 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/3058c82b689803f9031a4fbfa1d7cd7f4b856b07..257158ee0bffba0301e3159eea056a0e118c4f0a Suspect : https://chromium.googlesource.com/chromium/src/+/257158ee0bffba0301e3159eea056a0e118c4f0a @kristipark : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Issue is observed only for the first NTP and it works fine for rest of the new tab pages. 2. This issue is not observed on Mac 10.13.1 OS 3. Issue can be consistently reproduced on Win 10 OS
,
Apr 2 2018
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88af3486a1f112d89e21d47e9cff9b9374c0ecae commit 88af3486a1f112d89e21d47e9cff9b9374c0ecae Author: kristipark <kristipark@chromium.org> Date: Tue Apr 03 03:43:17 2018 Remove z-index of OneGoogleBar to place it above ntp-contents. The z-index fix for the theme attribution placed the OneGoogleBar behind the ntp-contents div, which made the OneGoogleBar unclickable. Removing the z-index of OneGoogleBar fixes it from being rendered below ntp-contents. Bug: 827969 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5d36f8b1c727a614ef6e2707a440af5413ecbc57 Reviewed-on: https://chromium-review.googlesource.com/990235 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#547616} [modify] https://crrev.com/88af3486a1f112d89e21d47e9cff9b9374c0ecae/chrome/browser/resources/local_ntp/local_ntp.css
,
Apr 3 2018
This was caused by the fix in https://crbug/823068, so requesting merge approval for M66.
,
Apr 3 2018
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 3 2018
Thanks kristipark@ - can you please check if this has landed in Canary? Is this a safe merge overall?
,
Apr 3 2018
This should be a safe merge (removes one line of css). It just missed the recent Canary push, so it'll land in the next.
,
Apr 4 2018
Update : Retested above issue in latest Canary #67.0.3388.0 build on Mac(10.12.6, 10.13.4), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. 'Gmail', 'Images' links on NTP are clickable for the first instance and all links are working as intended. Kindly review an attached screen-cast. Thank you!
,
Apr 4 2018
Approving merge to M66. Branch:3359
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd728d9a1074bab7ca2d579dbc243489bd968d7b commit bd728d9a1074bab7ca2d579dbc243489bd968d7b Author: kristipark <kristipark@chromium.org> Date: Wed Apr 04 19:27:40 2018 Remove z-index of OneGoogleBar to place it above ntp-contents. The z-index fix for the theme attribution placed the OneGoogleBar behind the ntp-contents div, which made the OneGoogleBar unclickable. Removing the z-index of OneGoogleBar fixes it from being rendered below ntp-contents. Bug: 827969 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5d36f8b1c727a614ef6e2707a440af5413ecbc57 Reviewed-on: https://chromium-review.googlesource.com/990235 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#547616}(cherry picked from commit 88af3486a1f112d89e21d47e9cff9b9374c0ecae) Reviewed-on: https://chromium-review.googlesource.com/996292 Cr-Commit-Position: refs/branch-heads/3359@{#578} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/bd728d9a1074bab7ca2d579dbc243489bd968d7b/chrome/browser/resources/local_ntp/local_ntp.css
,
Apr 12 2018
Update : Retested above issue in latest Beta build #66.0.3359.106 on Windows(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS and the issue is fixed. Kindly review an attached screen-cast. Thank you! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rbasuvula@chromium.org
, Apr 2 2018