Issue metadata
Sign in to add a comment
|
Regression: 'Show Password' icon and the CONNECT button both gets operated when we hit enter by keeping the focus on 'Show Password' icon |
||||||||||||||||||||||
Issue descriptionChrome Version:67.0.3383.0/10538.0.0 dev channel Candy,Peppy,Celes OS:Chrome OS What steps will reproduce the problem? (1)Recover Build >>go to 'Connect to a Network' overlay (2)Open any Join WiFi network overlay >> Give password (3)By tabbing bring the focus on 'Show Password' icon (4)Hit Enter key and observe(Please refer video) Expected: On hitting Enter key,'Show Password' icon should only be operated since focus is on it. Actual: Instead, both the 'Show Password' icon and the CONNECT button also gets operated when the focus on 'Show Password' icon This is a Regression issue as same is working fine in 65.0.3325.167/10323.58.0 Note: 1.Issue is not seen in Linux,Windows OS 2. Issue is also seen in M-66 Beta @stevenjb: Please confirm the issue.
,
May 14 2018
,
Jun 12 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5d388e5953ca7ac444f2644a1cf5769a1aa2103 commit d5d388e5953ca7ac444f2644a1cf5769a1aa2103 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Jun 14 19:50:41 2018 Settings > Network: Remove incorrect use of iron-a11y-keys iron-a11y-keys is not scoped, i.e. it is global within a component, so it is not a good choice for complex components. Bug: 827953 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I65ce312f3476a85d75b2f806ecd5fac7ec70fe12 Reviewed-on: https://chromium-review.googlesource.com/1100311 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567379} [modify] https://crrev.com/d5d388e5953ca7ac444f2644a1cf5769a1aa2103/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/d5d388e5953ca7ac444f2644a1cf5769a1aa2103/ui/webui/resources/cr_components/chromeos/network/network_password_input.html [modify] https://crrev.com/d5d388e5953ca7ac444f2644a1cf5769a1aa2103/ui/webui/resources/cr_components/chromeos/network/network_password_input.js [modify] https://crrev.com/d5d388e5953ca7ac444f2644a1cf5769a1aa2103/ui/webui/resources/cr_components/chromeos/network/network_proxy.html [modify] https://crrev.com/d5d388e5953ca7ac444f2644a1cf5769a1aa2103/ui/webui/resources/cr_components/chromeos/network/network_proxy.js [modify] https://crrev.com/d5d388e5953ca7ac444f2644a1cf5769a1aa2103/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
,
Jun 14 2018
,
Jun 14 2018
Fixed in 69. Doesn't seem critical enough to merge to 68.
,
Jun 18 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Apr 2 2018