Issue metadata
Sign in to add a comment
|
Regression : Default Focus is seen missing at 'PIN' field after clicking on 'Backspace' option in 'Enter your PIN' overlay of chrome://settings/lockScreen page |
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3383.0/10538.0.0 dev channel Candy, Peppy and Celes OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option 2)Now enter User Password in 'Confirm your password' dialog box -> At 'screen lock options' section select 'PIN or Password' option -> click on 'SET UP PIN' (3)In 'Enter your PIN' overlay click on 'Backspace' option and observe cursor is seen missing at 'PIN' field (Please refer Video) Expected: Default Focus in 'PIN' field should be seen even on clicking 'Backspace' option Actual: Instead Default Focus is seen missing at 'PIN' field after clicking on 'Backspace' option This is Regression Issue as same is working fine in M-66 @sammiequon : Please confirm the Issue
,
Apr 12 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ded99fb53f4c236bbd3b1a3ee4641f648b91c200 commit ded99fb53f4c236bbd3b1a3ee4641f648b91c200 Author: Sammie Quon <sammiequon@google.com> Date: Thu Apr 12 20:40:58 2018 settings: Fix focus issues with lock screen. 1) Fix pin keyboard shifting when going from message to no message. 2) Fix loosing focus on input when clicking disabled backspace - it will also not loose focus anymore if anywhere on the PIN keyboard is clicked. 3) Fix no focus on input when directly going to lockscreen (chrome:settings/lockScreen). Test: manual Bug: 828450, 827948 , 827126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id64b80287c6667a419f186cf67d7b77c62cf02d1 Reviewed-on: https://chromium-review.googlesource.com/1006262 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#550345} [modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/chrome/browser/resources/settings/people_page/password_prompt_dialog.js [modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/chrome/browser/resources/settings/people_page/setup_pin_dialog.html [modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/ded99fb53f4c236bbd3b1a3ee4641f648b91c200/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.js |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Apr 12 2018