New issue
Advanced search Search tips

Issue 827939 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 840704

Blocking:
issue 803774



Sign in to add a comment

Implement OriginTrial for SignedHTTPExchange

Project Member Reported by horo@chromium.org, Apr 2 2018

Issue description

We don't have any detailed schedule of the OriginTrial for SignedHTTPExchange yet.

But we should investigate how to implement and start the OriginTrial.
 

Comment 1 by horo@chromium.org, Apr 2 2018

Blocking: 803774
Components: Blink>Loader
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a81ad1578024ba2d76fe820a1666c7f92f76dcf

commit 8a81ad1578024ba2d76fe820a1666c7f92f76dcf
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Sat Apr 07 06:35:29 2018

Introduce Mojo API for SignedHTTPExchange LayoutTests

This CL introduces SetSignedExchangeVerificationTime() Mojo API for LayoutTests.
This API will be called from LayoutTests using Mojo JS.

The LayoutTests for SignedHTTPExchange will be added by crrev.com/c/991627
using the API.

Bug:  827939 
Change-Id: Ie2a3672bbf9df4d3f539c3d52d60474ea6c041e8
Reviewed-on: https://chromium-review.googlesource.com/991833
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549044}
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/browser/BUILD.gn
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/browser/storage_partition_impl.h
[add] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/browser/web_package/web_package_context_impl.cc
[add] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/browser/web_package/web_package_context_impl.h
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/public/browser/BUILD.gn
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/public/browser/storage_partition.h
[add] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/public/browser/web_package_context.h
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/public/test/test_storage_partition.cc
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/public/test/test_storage_partition.h
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/shell/browser/content_shell_browser_manifest_overlay.json
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/shell/browser/layout_test/blink_test_controller.h
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/third_party/WebKit/public/mojom/BUILD.gn
[add] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/third_party/WebKit/public/mojom/web_package/OWNERS
[add] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/third_party/WebKit/public/mojom/web_package/README.md
[add] https://crrev.com/8a81ad1578024ba2d76fe820a1666c7f92f76dcf/third_party/WebKit/public/mojom/web_package/web_package_internals.mojom

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12ed3c5be810ee8069c3d21c68c4d169ebfac46e

commit 12ed3c5be810ee8069c3d21c68c4d169ebfac46e
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Sat Apr 07 07:36:19 2018

Add LayoutTests for SignedHTTPExchange

These tests are using SetSignedExchangeVerificationTime() Mojo API which are
introduced by crrev.com/c/991833

Bug:  827939 
Change-Id: I142220f881fdca2ff22ca742a3e5e61a6f1e1966
Reviewed-on: https://chromium-review.googlesource.com/991627
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549048}
[modify] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/http/tests/loading/htxg/README.md
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-expired.html
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-location.html
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/127.0.0.1.pem.msg
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/README.md
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.html
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location.htxg
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-util.js
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/virtual/htxg-with-network-service/http/tests/loading/htxg/README.txt
[add] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/LayoutTests/virtual/htxg/http/tests/loading/htxg/README.txt
[modify] https://crrev.com/12ed3c5be810ee8069c3d21c68c4d169ebfac46e/third_party/WebKit/Tools/Scripts/apache_config/mime.types

Comment 5 by horo@chromium.org, May 8 2018

Blockedon: 840704
Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f

commit 46f5fffaa33c5c7b265d4694ed86e7c736c95b9f
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu May 10 12:33:35 2018

Introduce SignedHTTPExchangeOriginTrial feature

When this feature is enabled:
 - The Accept header of navigation requests will have
   "application/signed-exchange;v=b0".
 - If the response HTTP header has a valid Origin-Trial header for
   "SignedHTTPExchange", and the Content-Type header is
   "application/signed-exchange;v=b0", Chrome handles the response as
   SignedHTTPExchange.
 - Otherwise, the navigation loading will fail.

Bug:  827939 
Change-Id: Ib4906388cd6939df51244478d3e7a31df6c43652
Reviewed-on: https://chromium-review.googlesource.com/985993
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557495}
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/loader/mime_sniffing_resource_handler.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/loader/navigation_url_loader_impl.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/loader/prefetch_url_loader.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/loader/resource_requester_info.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/web_package/signed_exchange_handler.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/web_package/signed_exchange_url_loader_factory_for_non_network_service.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/web_package/signed_exchange_utils.h
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/web_package/web_package_loader.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/web_package/web_package_prefetch_handler.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/web_package/web_package_prefetch_handler.h
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/browser/web_package/web_package_request_handler.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/public/common/content_features.cc
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/content/public/common/content_features.h
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-expired.html
[add] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-location-origin-trial.html
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/http/tests/loading/htxg/htxg-location.html
[add] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-location-origin-trial.php
[modify] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/http/tests/loading/htxg/resources/htxg-util.js
[add] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/virtual/htxg-origin-trial-with-network-service/http/tests/loading/htxg/README.txt
[add] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/virtual/htxg-origin-trial-with-network-service/http/tests/loading/htxg/htxg-location-expected.txt
[add] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/virtual/htxg-origin-trial/http/tests/loading/htxg/README.txt
[add] https://crrev.com/46f5fffaa33c5c7b265d4694ed86e7c736c95b9f/third_party/WebKit/LayoutTests/virtual/htxg-origin-trial/http/tests/loading/htxg/htxg-location-expected.txt

Cc: cha...@chromium.org
Labels: -Pri-3 SignedExchange-b1 Pri-2
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eac6244920696e44f68d8ed36db8e68baea36e2

commit 2eac6244920696e44f68d8ed36db8e68baea36e2
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Oct 09 06:16:24 2018

Enable SignedHTTPExchangeOriginTrial by default

Bug:  827939 
Change-Id: I68c9d01898f530736bbcea2c10dbb859ac8dc745
Reviewed-on: https://chromium-review.googlesource.com/c/1270200
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597814}
[modify] https://crrev.com/2eac6244920696e44f68d8ed36db8e68baea36e2/content/browser/web_package/signed_exchange_request_handler_browsertest.cc
[modify] https://crrev.com/2eac6244920696e44f68d8ed36db8e68baea36e2/content/public/common/content_features.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05c9e079c2c1b5e3cbc0b72e934fc5b6b8582a0e

commit 05c9e079c2c1b5e3cbc0b72e934fc5b6b8582a0e
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Oct 09 08:55:42 2018

Signed Exchange: Fix feature name for TrialTokenValidator

We use SignedHTTPExchangeOriginTrial as the feature name of the origin
trial, but ShouldHandleAsSignedHTTPExchange() was using
SignedHTTPExchange.

Bug:  827939 
Change-Id: Idddfc8f9bd96d5b2c018863bcdd952feefa88d7e
Reviewed-on: https://chromium-review.googlesource.com/c/1270499
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597844}
[modify] https://crrev.com/05c9e079c2c1b5e3cbc0b72e934fc5b6b8582a0e/content/browser/web_package/signed_exchange_utils.cc
[modify] https://crrev.com/05c9e079c2c1b5e3cbc0b72e934fc5b6b8582a0e/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-location-origin-trial.php

Status: Fixed (was: Assigned)

Sign in to add a comment