New issue
Advanced search Search tips

Issue 827936 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 857295



Sign in to add a comment

Support to control the maximum image decoded size according to the user definition for the embedded device

Project Member Reported by gyuyoung...@chromium.org, Apr 2 2018 
Embedded devices usually have limited storage and memory size. So it would be great if we can give them the power to limit memory or storage usage. To do it, I've landed some command lines to limit the usage of memory or storage -  crbug.com/823210 ,  crbug.com/824619 .

As one of them, I'd like to introduce a new command line to control the image decoded size for embedded devices. According to the comment of |ImageDecoder::max_decoded_bytes_|, the decoded image size should be limited if it causes excessive memory or even crashes on low-memory devices. 

- https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h?q=ImageDecoder.h&sq=package:chromium&dr=CSs&l=377


IMHO, it would be good if we give embedders the power to limit the memory usage of image decoded size.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16b1798c844c1247cce6d38d17fd131969bfc203

commit 16b1798c844c1247cce6d38d17fd131969bfc203
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Tue Apr 03 02:15:02 2018

Support to set the maximum decoded image bytes through a command line

This CL introduces a new command line to control the image decoded size
for embedded devices. According to the comment of |ImageDecoder::max_decoded_bytes_|,
the decoded image size should be limited if it causes excessive memory
or even crashes on low-memory devices. It would be good if we give embedders
the power to limit the memory usage of image decoded size.

Bug:  827936 
Change-Id: Ia67fc12f8f8554a6dcc0b42ea07e80d0d4dee2ce
Reviewed-on: https://chromium-review.googlesource.com/989382
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#547604}
[modify] https://crrev.com/16b1798c844c1247cce6d38d17fd131969bfc203/content/child/blink_platform_impl.cc
[modify] https://crrev.com/16b1798c844c1247cce6d38d17fd131969bfc203/content/public/common/content_switches.cc
[modify] https://crrev.com/16b1798c844c1247cce6d38d17fd131969bfc203/content/public/common/content_switches.h

Comment 2 by gyuyoung...@chromium.org, Jun 28 2018

Status: Fixed (was: Untriaged)

Comment 3 by gyuyoung...@chromium.org, Jun 28 2018

Blocking: 857295
►

Sign in to add a comment