New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827934 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 800659



Sign in to add a comment

Add Connector Java class which provides abilities of "connecting services" and "binding interface" to java user.

Project Member Reported by ke...@intel.com, Apr 2 2018

Issue description

Geolocation exposes a static java method to the embedder:  
LocationProviderFactory::useGmsCoreLocationProvider(), by which embedder can choose to use the GMS LocationProvider instead of using the default Android system LocationProvider.

We have to convert that directly function call into a mojo call, so we have to Add a Connector Java class which can suppport user to connect Device Service in Java world.

 

Comment 1 by ke...@intel.com, Apr 2 2018

Blocking: 800659

Comment 2 by ke...@intel.com, Apr 3 2018

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8

commit 4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8
Author: Ke He <ke.he@intel.com>
Date: Fri May 18 10:08:01 2018

Add Connector to Service Manager Java APIs

Add Connector and ServiceManagerConnection classes which expose the ability
to bind interfaces from other services in the system.

Also add the ConnectorTest.java as a browsertest which use the Connector and
ServiceManagerConnection to connect the echo service.

BUG= 827934 

Change-Id: I84addef979c193ecc1bb379dbf8f1be58994aa4e
Reviewed-on: https://chromium-review.googlesource.com/989839
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#559853}
[modify] https://crrev.com/4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8/content/common/service_manager/service_manager_connection_impl.cc
[modify] https://crrev.com/4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8/content/public/android/BUILD.gn
[add] https://crrev.com/4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8/content/public/android/java/src/org/chromium/content/common/ServiceManagerConnectionImpl.java
[add] https://crrev.com/4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8/content/public/android/java/src/org/chromium/content_public/common/ServiceManagerConnection.java
[add] https://crrev.com/4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8/content/public/android/javatests/src/org/chromium/content/common/ServiceManagerConnectionImplTest.java
[modify] https://crrev.com/4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8/services/service_manager/public/java/BUILD.gn
[add] https://crrev.com/4995fb767fee0cb6896594dfe6dbd2bd6ab2b2d8/services/service_manager/public/java/src/org/chromium/services/service_manager/Connector.java

Project Member

Comment 4 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/793a2e7267d4e792975e72a8161f58f90c6fa918

commit 793a2e7267d4e792975e72a8161f58f90c6fa918
Author: Ke He <ke.he@intel.com>
Date: Tue May 22 01:18:45 2018

Remove Looper in ServiceManagerConnectionImplTest.

The Looper doesn't explicitly support nested looping, it is the root loop and
will be broken after a quit call, in this case the remaining cleanup of the
test might be broken.

BUG= 827934 

Change-Id: I70f1081d1044328d70b50f6a60153dbfd699d153
Reviewed-on: https://chromium-review.googlesource.com/1067239
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#560444}
[modify] https://crrev.com/793a2e7267d4e792975e72a8161f58f90c6fa918/content/public/android/javatests/src/org/chromium/content/common/ServiceManagerConnectionImplTest.java

Comment 5 by ke...@intel.com, May 31 2018

Status: Fixed (was: Started)
This doesn't block geolocation servicification work. See commit message in 21ee87ff88dcc072d00a9700400fe1ce410cd106

Sign in to add a comment