Cubic bezier editor difficult to see when using dark theme in dev tools
Reported by
scottedi...@btinternet.com,
Apr 1 2018
|
||||
Issue description
Chrome Version : 65.0.3325.181
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari:
Firefox:
IE/Edge:
What steps will reproduce the problem?
1.
2.
3.
What is the expected result?
What happens instead of that?
Please provide any additional information below. Attach a screenshot if
possible.
UserAgentString: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36
Would it be possible to change the colours of the cubic bezier editor when using the dark theme. It's not easy to see when you have your monitor brightness turned down at night. Or is there some way I could customize it? Thank you.
,
Apr 2 2018
Thanks for the report, the black-on-gray curve could have better contrast. I'll take a look.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70b4f9f0210b0995a846262c8ef848dbf4bae211 commit 70b4f9f0210b0995a846262c8ef848dbf4bae211 Author: Erik Luo <luoe@chromium.org> Date: Wed May 23 02:20:10 2018 DevTools: update dark theme for components using fill, stroke Screenshot: https://imgur.com/a/lhjvp3U Bug: 827860 Change-Id: Ib42840136d4705bf90433e4ee308cf40417a610f Reviewed-on: https://chromium-review.googlesource.com/1068245 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#560896} [modify] https://crrev.com/70b4f9f0210b0995a846262c8ef848dbf4bae211/third_party/blink/renderer/devtools/front_end/color_picker/spectrum.css [modify] https://crrev.com/70b4f9f0210b0995a846262c8ef848dbf4bae211/third_party/blink/renderer/devtools/front_end/inline_editor/bezierEditor.css [modify] https://crrev.com/70b4f9f0210b0995a846262c8ef848dbf4bae211/third_party/blink/renderer/devtools/front_end/ui/UIUtils.js
,
May 24 2018
Able to reproduce the issue on chrome reported version 65.0.3325.181 Verified the fix on Windows-7 on Chrome version #68.0.3439.0 as per the comment#0 Attaching screenshot for reference. Observed "Components got updated for dark theme in Devtools" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
May 24 2018
That looks much better, thank you very much for the fix.
,
May 24 2018
Thanks for your patience! Marking as fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by vamshi.kommuri@chromium.org
, Apr 1 2018Labels: Needs-Triage-M65