New issue
Advanced search Search tips

Issue 827748 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 822505



Sign in to add a comment

Add test coverage for PDFToEmfConverter in PostScript mode.

Project Member Reported by thestig@chromium.org, Mar 31 2018 
PDFToEmfConverter can actually generate PostScript in addition to EMF. This was added in r447440 and related CLs.

In PS mode, the output is encapsulate inside an EMF for transport. The output is then read out of the EMF and sent to the Windows printing subsystem when printing to a PS capable printer.

This feature had some bugs / regressions. e.g.  bug 767343  and  bug 806746 . We should add more test coverage to catch them.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16

commit 46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Apr 03 17:12:41 2018

Add PdfToEmfConverterBrowserTest tests for PostScript mode.

BUG= 827748 

Change-Id: Id011527d001ffbb70130bfee085e4a21b80c8100
Reviewed-on: https://chromium-review.googlesource.com/989287
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547740}
[modify] https://crrev.com/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16/chrome/browser/printing/pdf_to_emf_converter_browsertest.cc
[rename] https://crrev.com/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16/chrome/test/data/printing/pdf_converter_basic.pdf
[rename] https://crrev.com/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16/chrome/test/data/printing/pdf_converter_basic_emf_page_1.emf
[rename] https://crrev.com/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16/chrome/test/data/printing/pdf_converter_basic_emf_page_2.emf
[rename] https://crrev.com/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16/chrome/test/data/printing/pdf_converter_basic_emf_page_3.emf
[add] https://crrev.com/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16/chrome/test/data/printing/pdf_converter_basic_ps_page_1.emf
[add] https://crrev.com/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16/chrome/test/data/printing/pdf_converter_basic_ps_page_2.emf
[add] https://crrev.com/46c63c19c18e2c5b63e9b2ecc09e5899b36e6b16/chrome/test/data/printing/pdf_converter_basic_ps_page_3.emf
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d6a20b06353e6b286d2ed2fa98d22ea94cda63

commit c8d6a20b06353e6b286d2ed2fa98d22ea94cda63
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Apr 03 18:55:51 2018

Add regression test for  bug 767343 .

Make sure there is no text output when converting from PDF to PS for
text with size 0.

BUG= 767343 , 827748 

Change-Id: Id788b1f936d4f97b2201b7171a756a7ec2892bf1
Reviewed-on: https://chromium-review.googlesource.com/989299
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547779}
[modify] https://crrev.com/c8d6a20b06353e6b286d2ed2fa98d22ea94cda63/chrome/browser/printing/pdf_to_emf_converter_browsertest.cc
[add] https://crrev.com/c8d6a20b06353e6b286d2ed2fa98d22ea94cda63/chrome/test/data/printing/bug_767343.emf
[add] https://crrev.com/c8d6a20b06353e6b286d2ed2fa98d22ea94cda63/chrome/test/data/printing/bug_767343.pdf
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18655670691d26f33e8bd1e271a0e6643562972e

commit 18655670691d26f33e8bd1e271a0e6643562972e
Author: Lei Zhang <thestig@chromium.org>
Date: Wed Apr 04 01:57:26 2018

Add regression test for  bug 806746 .

Make sure there is text output when converting from PDF to PS for text
with negative size, which should be rendered rotated 180 degrees with
respect to the origin.

BUG= 806746 , 827748 

Change-Id: Ia214f25f8fdb945ecb5a046e07313e3237b2cf84
Reviewed-on: https://chromium-review.googlesource.com/989424
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547940}
[modify] https://crrev.com/18655670691d26f33e8bd1e271a0e6643562972e/chrome/browser/printing/pdf_to_emf_converter_browsertest.cc
[add] https://crrev.com/18655670691d26f33e8bd1e271a0e6643562972e/chrome/test/data/printing/bug_806746.emf
[add] https://crrev.com/18655670691d26f33e8bd1e271a0e6643562972e/chrome/test/data/printing/bug_806746.pdf

Comment 4 by thestig@chromium.org, Apr 4 2018

Status: Fixed (was: Assigned)
Calling this one fixed.
►

Sign in to add a comment