New issue
Advanced search Search tips

Issue 827741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

Convert PpdProvider to SimpleURLLoader

Project Member Reported by skau@chromium.org, Mar 31 2018

Issue description

Per https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/TYUaUzgLsOw URLFetcher is deprecated and we should switch ASAP
 

Comment 1 by luum@chromium.org, May 30 2018

Owner: luum@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b30c811da0256f1fd726f05e94732ce1c61b4072

commit b30c811da0256f1fd726f05e94732ce1c61b4072
Author: Luum Habtemariam <luum@chromium.org>
Date: Mon Jun 25 21:51:22 2018

PpdProvider network::SimpleURLLoader refactor

net::URLFetcher is no longer being maintained in lieu of
network::SimpleURLLoader. This cl brings PpdProvider inline with this
api change.

Test: passes unittests && manual tests
Bug:  chromium:827741 
Change-Id: I12c329b5a62809a56eca158baaed40f70b7b839a
Reviewed-on: https://chromium-review.googlesource.com/1095537
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570191}
[modify] https://crrev.com/b30c811da0256f1fd726f05e94732ce1c61b4072/chrome/browser/chromeos/printing/ppd_provider_factory.cc
[modify] https://crrev.com/b30c811da0256f1fd726f05e94732ce1c61b4072/chromeos/BUILD.gn
[modify] https://crrev.com/b30c811da0256f1fd726f05e94732ce1c61b4072/chromeos/DEPS
[modify] https://crrev.com/b30c811da0256f1fd726f05e94732ce1c61b4072/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/b30c811da0256f1fd726f05e94732ce1c61b4072/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/b30c811da0256f1fd726f05e94732ce1c61b4072/chromeos/printing/ppd_provider_unittest.cc

Comment 3 by luum@chromium.org, Jun 25 2018

Status: Fixed (was: Started)

Sign in to add a comment