WeakMap HeapProfiler Show retaining key
Reported by
kris.sel...@gmail.com,
Mar 30 2018
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36 Steps to reproduce the problem: Without knowing what the key is, debugging memory leaks via WeakMaps is quite hard. What is the expected behavior? What went wrong? Can't see retaining path through key Did this work before? No Chrome version: 65.0.3325.181 Channel: stable OS Version: OS X 10.12.6 Flash Version:
,
Apr 1 2018
,
Apr 2 2018
The clientBuilder is the key. We can make the label "7 / key in WeakMap". Would that help? 2206 is the index of the value in the backing store of the WeakMap.
,
Apr 2 2018
,
Apr 3 2018
@ulan, let me check with Kris. But yes, I believe `7 / key clientBuild in WeakMap` might make it more discoverable. Obviously, once you explained it. It was obvious, but I think `7 /` alone is likely not super friendly.
,
Apr 3 2018
I uploaded https://chromium-review.googlesource.com/c/v8/v8/+/992035 for review.
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/12708c93e1619c80fcf419d2ff1d9840779ce6d0 commit 12708c93e1619c80fcf419d2ff1d9840779ce6d0 Author: Ulan Degenbaev <ulan@chromium.org> Date: Mon Apr 09 07:32:20 2018 [heap-profiler] Make WeakMap key edge name more descriptive. Currently a WeakMap key edge shows up as '<id> / WeakMap'. This patch changes it to '<id> / key <KeyName> in WeakMap'. Bug: chromium:827713 Change-Id: I0306bacdc331ab69739be88cf29d16a21187625f Reviewed-on: https://chromium-review.googlesource.com/992035 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52465} [modify] https://crrev.com/12708c93e1619c80fcf419d2ff1d9840779ce6d0/src/profiler/heap-snapshot-generator.cc [modify] https://crrev.com/12708c93e1619c80fcf419d2ff1d9840779ce6d0/test/cctest/test-heap-profiler.cc
,
Apr 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by spen...@linkedin.com
, Mar 30 2018