New issue
Advanced search Search tips

Issue 827696 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

SVG parser should report correct offset for script tags

Project Member Reported by kozy@chromium.org, Mar 30 2018

Issue description

Chrome Version: 67.0.3383.0
OS: all

What steps will reproduce the problem?
(1) open [1] in Chrome
(2) open DevTools, request pause, reload
(3) wait for pause press step-into couple of times

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/svg/text/vertical-surrogate-pairs.html?type=cs&q=%22%3Cdesc%3ETest+if+auto+glyph+orientation+in%22&sq=package:chromium&l=3

What is the expected result?
debugger pauses inside script tag.

What happens instead?
debugger pauses outside of script tag.
 

Comment 1 by f...@opera.com, Mar 31 2018

Components: Blink>HTML>Parser
Any update on this? It's blocking https://chromium-review.googlesource.com/c/chromium/src/+/986337.

Comment 3 by kozy@chromium.org, Apr 4 2018

I found the root and uploaded speculative fix: https://chromium-review.googlesource.com/c/chromium/src/+/996531
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb1540c5b74dda39d85d2eda2e488c037252ffb

commit 8cb1540c5b74dda39d85d2eda2e488c037252ffb
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Apr 05 19:54:55 2018

[svg] parser should provide proper position for script tag inside svg tags

Proper script offset is important for DevTools and JavaScript stacks.

Bug:  chromium:827696 
Change-Id: I9786e41b63cea532637b573505ae445f90d866cf
Reviewed-on: https://chromium-review.googlesource.com/996531
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548531}
[add] https://crrev.com/8cb1540c5b74dda39d85d2eda2e488c037252ffb/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-script-inside-svg-expected.txt
[add] https://crrev.com/8cb1540c5b74dda39d85d2eda2e488c037252ffb/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-from-script-inside-svg.js
[add] https://crrev.com/8cb1540c5b74dda39d85d2eda2e488c037252ffb/third_party/WebKit/LayoutTests/http/tests/devtools/console/resources/svg.html
[modify] https://crrev.com/8cb1540c5b74dda39d85d2eda2e488c037252ffb/third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/script-tag-inside-svg-tag4-expected.txt
[modify] https://crrev.com/8cb1540c5b74dda39d85d2eda2e488c037252ffb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp

Comment 5 by kozy@chromium.org, Apr 5 2018

Status: Fixed (was: Assigned)

Sign in to add a comment