New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827692 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-04-25
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] testRevertCulprit is flaky

Project Member Reported by wylieb@chromium.org, Mar 30 2018

Issue description

Reenable when ready
 
Owner: ----
Status: Available (was: Assigned)

Comment 3 by st...@chromium.org, Apr 3 2018

Labels: -Pri-3 Pri-1
Could we find an owner to follow up and fix this?

Revert is a critical part in Findit, and we'd better not have flaky tests like this there.
I can take this and also 827691. But do you have error logs on this? I haven't seen any flakiness for those tests, and don't know if I can reproduce them
I don't have the logs, just turned them off since they closed the tree.
I found failed builds because of testIdentifyCulpritForTestTryJobSuccess but not this testRevertCulprit. Are you sure this one is really flaky?

Comment 7 by st...@chromium.org, Apr 10 2018

Owner: chanli@chromium.org
Status: Assigned (was: Available)
chanli@: I'd assign to you to follow up as it is related to auto-revert.

Comment 8 by chanli@chromium.org, Apr 10 2018

As I said in comment#6, I don't find any evidence that this test is flaky. If I couldn't get more info, I'll just re-enable this test.

Comment 9 by chanli@chromium.org, Apr 18 2018

I don't get any updates on this. I plan to re-enable this test for now, and fix it if it flakes again so I can have logs to investigate.
NextAction: 2018-04-25
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/90e42934768e97c3525e710f26dae2e78b9c82b2

commit 90e42934768e97c3525e710f26dae2e78b9c82b2
Author: Chan <chanli@chromium.org>
Date: Wed Apr 18 20:32:59 2018

[Findit] re-enable testRevertCulprit

Bug:  827692 
Change-Id: I098be30f318e2d4cebfb915d1c0d4026b41c14bf
Reviewed-on: https://chromium-review.googlesource.com/1017767
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/90e42934768e97c3525e710f26dae2e78b9c82b2/appengine/findit/services/test/culprit_action_test.py

The NextAction date has arrived: 2018-04-25
Status: WontFix (was: Assigned)

Sign in to add a comment