Exit VR dialog should use Cancel text on button, not OK |
|||||
Issue descriptionChrome Version: 67.0.3384.0 Canary OS: Android 8.1.0 on Pixel 2 What steps will reproduce the problem? (1) Enter VR Browsing (2) Trigger the Exit VR dialog, note new dialog is displayed. What is the expected result? The button to return the user to VR should not say OK, it should be maybe Cancel. What happens instead? The OK button is a little misleading, need something that more clearly indicated that the user will be returned to VR.
,
May 4 2018
My take — the buttons are reversed, and use the wrong terms. Instead of: [Exit VR] [OK] (with Exit VR secondary) ...the buttons should be: [Cancel] [Exit VR] (with Exit VR primary) Emailing Shimi for further thoughts.
,
May 4 2018
I agree w/Gordon about the order. For the secondary button, because no operation was started and then canceled, "Cancel" doesn't feel quite right. What about "Back"? Presuming the user is taken back to whatever state they were in before they tried to use the unsupported-in-VR feature.
,
May 9 2018
I just refactored the prompt. I'll assume this as the code is fresh in my head.
,
May 11 2018
Thank you srahim! That's a great point. So to recap, we're updating buttons to be: [Back] [Exit VR] (with "Exit VR" as primary)
,
May 23 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92e232642e3a174df5530b6a5b090272cf04641e commit 92e232642e3a174df5530b6a5b090272cf04641e Author: Christopher Grant <cjgrant@chromium.org> Date: Wed May 23 21:03:38 2018 VR: Improve prompt button text and order according to UX This change makes VR exit prompt's primary action 'EXIT VR', and the secondary button 'BACK', as per discussion on the bug. BUG= 827681 R=bshe Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I2f3c264ea9f7130b3d45532df2167573f17ce289 Reviewed-on: https://chromium-review.googlesource.com/1070485 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#561253} [modify] https://crrev.com/92e232642e3a174df5530b6a5b090272cf04641e/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/92e232642e3a174df5530b6a5b090272cf04641e/chrome/browser/vr/ui_unittest.cc
,
May 24 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by asimjour@chromium.org
, Apr 3 2018Status: Assigned (was: Untriaged)