Re (1), that's the current state, but we will want to look as some potentially data heavy services are rolled out soon.

(Taking the task.)

bengr@ Sorry if I misunderstood, but do you mean there are some coming services that rely on data_use_measurement, and we shouldn't remove it now?
If so can you point me to how they are using the feature, and I will check if we can switch to using NetworkTrafficAnnotationTag instead?

Thanks!

pnoland@ can provide details on the coming services. 

Separately, https://bugs.chromium.org/p/chromium/issues/detail?id=808498 is relevant. ryansturm@ was thinking about how to support data use measurement post-servicification. I believe he has a design doc as we ll.

The services don't and won't rely on data_use_measurement, but we will want to be able to measure the amount of data they use. Supporting data use accounting via NetworkTrafficAnnotationTag would be sufficient for our purposes.

pnoland@ Thanks for the info and good to know NetworkTrafficAnnotationTag works!

ryansturm@ is currently OOO, will wait for his input before proceeding.

ryansturm@ Can you comment on this issue? Thanks!

Yup. I sent out a design doc to Chrome-design-docs recently. The code for that will currently still live in components/data_use_measurement, but should be able to be moved to //services/ or elsewhere if needed. I believe we'll be able to remove the network delegates in data_use_measurement (raj might depend on them until full launch of servicification though). It is my belief that we can remove the code measuring internal chrome service data usage altogether, and we will add the full post-mojo implementation in a later milestone.

Thanks Ryan. Removing Chong as owner then.

rajendrant might have more to add to this as well.

I am working on migrating services data use metrics to use NetworkTrafficAnnotations. This will simplify resurrecting the datause metrics post network-servicification.

https://bugs.chromium.org/p/chromium/issues/detail?id=843715

After ryansturm@ work mentioned in #c7 is complete, the remaining piece of data_use_measurement will be moved away from using network delegate.

Removing data_use_measurement affects UMA log uploads in cellular. There is a weekly quota logic that uses usertraffic, services traffic from data_use_measurement.

https://cs.chromium.org/chromium/src/components/metrics/data_use_tracker.h

Assign to Raj to determine what to do with this issue. Can you summarize our uses and plan for data_use_measurement?

Any updates?

Refreshed during triage. Updates?

Refreshed during triage. Ray, please update status here? Anything blocking? Any target milestone?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af64d71759d06b23695b52d5da55ea782c52ef0e

commit af64d71759d06b23695b52d5da55ea782c52ef0e
Author: rajendrant <rajendrant@chromium.org>
Date: Tue Jan 08 06:48:42 2019

Record user traffic histogram with network service

Bug: 827679
Change-Id: Ida233c9f620b5d7835fa7178f2ecfe70fc8a4956
Reviewed-on: https://chromium-review.googlesource.com/c/1399442
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620640}
[modify] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/chrome/browser/BUILD.gn
[modify] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/chrome/browser/data_use_measurement/chrome_data_use_measurement.cc
[modify] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/chrome/browser/data_use_measurement/chrome_data_use_measurement.h
[add] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/chrome/browser/page_load_metrics/observers/data_use_metrics_observer.cc
[add] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/chrome/browser/page_load_metrics/observers/data_use_metrics_observer.h
[modify] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/components/data_use_measurement/core/data_use_measurement.cc
[modify] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/components/data_use_measurement/core/data_use_measurement.h
[modify] https://crrev.com/af64d71759d06b23695b52d5da55ea782c52ef0e/components/data_use_measurement/core/data_use_measurement_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d83863b526ef9066a3bec37753e5223ad17042d

commit 1d83863b526ef9066a3bec37753e5223ad17042d
Author: rajendrant <rajendrant@chromium.org>
Date: Fri Jan 11 00:17:02 2019

Record user traffic data use breakdowns

Bug: 827679
Change-Id: I4f6da6c99e20608d7e128f7bade54407bc8404e6
Reviewed-on: https://chromium-review.googlesource.com/c/1404382
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621818}
[modify] https://crrev.com/1d83863b526ef9066a3bec37753e5223ad17042d/chrome/browser/data_use_measurement/chrome_data_use_measurement.cc
[modify] https://crrev.com/1d83863b526ef9066a3bec37753e5223ad17042d/chrome/browser/data_use_measurement/chrome_data_use_measurement.h
[modify] https://crrev.com/1d83863b526ef9066a3bec37753e5223ad17042d/chrome/browser/page_load_metrics/observers/data_use_metrics_observer.cc
[modify] https://crrev.com/1d83863b526ef9066a3bec37753e5223ad17042d/chrome/browser/page_load_metrics/observers/data_use_metrics_observer.h
[add] https://crrev.com/1d83863b526ef9066a3bec37753e5223ad17042d/chrome/browser/page_load_metrics/observers/data_use_metrics_observer_browsertest.cc
[modify] https://crrev.com/1d83863b526ef9066a3bec37753e5223ad17042d/chrome/test/BUILD.gn
[modify] https://crrev.com/1d83863b526ef9066a3bec37753e5223ad17042d/components/data_use_measurement/core/data_use_measurement.cc
[modify] https://crrev.com/1d83863b526ef9066a3bec37753e5223ad17042d/components/data_use_measurement/core/data_use_measurement.h