custom titlebar: top-right corner of maximized window doesn't activate the close button |
||||
Issue descriptionWith custom titlebar enabled: 1. Maximize the window. 2. Move mouse to the very top-right corner of the screen The close button should be hovered, and activate when clicked, but it currently does not. I thought it might be HiDPI related but it seems to repro at 1x too.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cce37ea23cb1e16bd129e5da36c960c5ab6012b8 commit cce37ea23cb1e16bd129e5da36c960c5ab6012b8 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Apr 03 00:50:18 2018 Fix custom Windows close button being 1 dip too far left. To match the OS the button should be flush with the right edge of the window. This was also causing the top-right pixel of the screen to not activate the button when the window was maximized. Bug: 827664 Change-Id: Ie9f6a080c9374a842be729702c33ddbde9199e7e Reviewed-on: https://chromium-review.googlesource.com/988845 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#547586} [modify] https://crrev.com/cce37ea23cb1e16bd129e5da36c960c5ab6012b8/chrome/browser/ui/views/frame/glass_browser_frame_view.cc [modify] https://crrev.com/cce37ea23cb1e16bd129e5da36c960c5ab6012b8/chrome/browser/ui/views/frame/windows_10_caption_button.cc [modify] https://crrev.com/cce37ea23cb1e16bd129e5da36c960c5ab6012b8/chrome/browser/ui/views/frame/windows_10_caption_button.h
,
Apr 3 2018
,
Apr 3 2018
Able to reproduce this issue on build without fix(Checked on 67.0.3382.0 HIDPI Win 10), Hence verifying the fix on latest canary 67.0.3387.0. Still not observing hover effect and not observing button activation when hovered on extreme top right corner of window. Attaching screencast for reference. @bsep: Please check the video and let us know if this the expected behavior. Please help in verifying the fix. Thanks!
,
Apr 3 2018
#4: That's odd. I just checked Canary and it's fixed for me. From the video, it looks like you're running into bug 656730 . You have to sign out and sign back in after changing HiDPI settings. Also, do not use multiple monitors to test this bug. Is it fixed if you use a non-HiDPI computer? The bug isn't HiDPI-specific, anyway. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bsep@chromium.org
, Mar 30 2018