New issue
Advanced search Search tips

Issue 827644 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 827649



Sign in to add a comment

D3D11 zero copy - obey dxva blacklist

Project Member Reported by liber...@chromium.org, Mar 30 2018

Issue description

dxva_video_decoder_win decides when to use zero-copy and when to copy.  make D3D11VideoDecoderImpl::Initialize do something similar.
 
Blocking: 827649
Owner: liber...@chromium.org
Status: Started (was: Available)
it would be nice to move this check to the renderer to save the ipc hop.  i'll do a simple version that still hops to the gpu, and we can see about moving it later.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9

commit 7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9
Author: Frank Liberato <liberato@chromium.org>
Date: Sat Apr 14 00:10:56 2018

Fail D3D11VideoDecoder init if unsupported config.

This CL makes sure that D3D11VideoDecoder is only used if:
 - NV12 textures
 - zero-copy textures are enabled
 - video is H264

Bug:  827644 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If0fe5a2fcd171af5ca2be2a2fa37fc2c14a6b01c
Reviewed-on: https://chromium-review.googlesource.com/1008249
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550821}
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/gpu/windows/d3d11_video_decoder.cc
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/gpu/windows/d3d11_video_decoder.h
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/gpu/windows/d3d11_video_decoder_impl.cc
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/mojo/services/gpu_mojo_media_client.cc
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/renderers/default_renderer_factory.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9

commit 7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9
Author: Frank Liberato <liberato@chromium.org>
Date: Sat Apr 14 00:10:56 2018

Fail D3D11VideoDecoder init if unsupported config.

This CL makes sure that D3D11VideoDecoder is only used if:
 - NV12 textures
 - zero-copy textures are enabled
 - video is H264

Bug:  827644 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If0fe5a2fcd171af5ca2be2a2fa37fc2c14a6b01c
Reviewed-on: https://chromium-review.googlesource.com/1008249
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550821}
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/gpu/windows/d3d11_video_decoder.cc
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/gpu/windows/d3d11_video_decoder.h
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/gpu/windows/d3d11_video_decoder_impl.cc
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/mojo/services/gpu_mojo_media_client.cc
[modify] https://crrev.com/7d75c1bc7c6c1e20dfae46e80fe57c7734bbd1c9/media/renderers/default_renderer_factory.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4ebf255bc7255bbb265dfc5291ca5d8cfe89abd

commit d4ebf255bc7255bbb265dfc5291ca5d8cfe89abd
Author: liberato@chromium.org <liberato@chromium.org>
Date: Mon Apr 23 06:51:54 2018

Check Gpu workarounds during D3D11VideoDecoder init.

Check that there aren't driver bug workarounds that prevent the
D3D11VideoDecoder from using zero-copy NV12 textures.

Bug:  827644 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibbc8a871242ed9a403c53494cb25b9298bcbcd05
Reviewed-on: https://chromium-review.googlesource.com/1019358
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552646}
[modify] https://crrev.com/d4ebf255bc7255bbb265dfc5291ca5d8cfe89abd/media/gpu/windows/d3d11_video_decoder.cc
[modify] https://crrev.com/d4ebf255bc7255bbb265dfc5291ca5d8cfe89abd/media/gpu/windows/d3d11_video_decoder.h
[modify] https://crrev.com/d4ebf255bc7255bbb265dfc5291ca5d8cfe89abd/media/gpu/windows/d3d11_video_decoder_unittest.cc
[modify] https://crrev.com/d4ebf255bc7255bbb265dfc5291ca5d8cfe89abd/media/mojo/services/gpu_mojo_media_client.cc

Status: Fixed (was: Started)

Sign in to add a comment