New issue
Advanced search Search tips

Issue 827642 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
M-X



Sign in to add a comment

MacViews: Subpixel anti-aliasing is slightly different

Project Member Reported by rsesek@chromium.org, Mar 30 2018

Issue description

Chrome Version: 67.0.3384.0
OS: macOS 10.13.3

Comparing screenshots of both the Omnibox drop-down and the Find in Page box, there are noticeable differences in the subpixel-anti-aliasing of text. On my non-retina monitor (a HP ZR30w Display) this does result in a visual difference in the text even when un-zoomed. Personally I find the Cocoa rendering superior.

Looking at the zoomed images, it looks like the "subpixels" have the same color value and layout, but different intensity/luminance. We should figure out why this differs.

Attached are the 100% images for Cocoa and Views, as well as super-zoomed-in, cropped comparisons. It's easiest to see in "find-compare.png", looking at the line of cyan pixels after the "l" in "hello".
 
find-cocoa.png
62.9 KB View Download
find-views.png
73.3 KB View Download
find-compare.png
109 KB View Download
omnibox-cocoa.png
100 KB View Download
omnibox-views.png
254 KB View Download
omnibox-compare.png
306 KB View Download
Labels: MacViews-Controls M-X
Status: Available (was: Untriaged)
For the find bar - is Cocoa just using a font that is 1pt bigger?

Default font size in Views (and the Harmony typography spec) is 12pt. But [NSFont systemFontSize] is 13. (and smallSystemFontSize is 11pt I think).

I... think it's coming from our ancient FindBar.xib on Cocoa, which has

  `<font key="font" metaFont="system"/>`

It's possible that just pumping the font size up a pixel will make the text more comfortable.

And for colors... it's actually intentional that we do not use solid black for text any more, so I would expect a slight intensity change. The "most black" that fonts should be under Harmony is #212121 and the most black they should be with the material refresh is kGoogleGrey800 (#3c4043) (chrome://flags/#top-chrome-md set to 'Touchable' or 'Refresh').
You're right – for the find bar there is a 1px difference in the 'l' height. For the Omnibox comparison, the 'h' height is the same. However it looks like in Cocoa, the color for the font is rgb(63,103,211) while in Views it's rgb(64,102,207).

So perhaps both are indeed related to slight color changes as well.

I do think the Cocoa variants look better, regardless. And it's a little odd to not be using the system font sizes if we're using the system font. **shrug**
Labels: Group-Views_Regressions_from_Cocoa
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIToolingRequired
***Mass UI Triage***

Sign in to add a comment