Downloading detail progress is overlapping the X icon when in Ukrainian |
|||
Issue descriptionApp Version: 67.0.3382.0 canary iOS Version: 11.3, 10.3.3 Device: iPhone 5S (small device) URL: thinkbroadband.com/download Precondition: Change device language to Ukrainian Steps to reproduce: 1. Launch Google Chrome 2. Navigate to above url and tap Download Observed results: Downloading detail progress is overlapping the X icon when in Ukrainian Expected results: Downloading detail progress should not overlap the X icon when in Ukrainian Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Bug reproducible on Safari/Firefox: Firefox: , Safari: Bug reproducible on current stable build (App Version, iOS Version): M65 NA (New feature) Bug reproducible on the current beta channel build (App Version, iOS Version): M66 NA (New Feature) Link to video/image: https://drive.google.com/file/d/1s3mfioeqoxL0nZKXiCo59g5LvEtSKsbE/view
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c25fd77397392105990e5af26893b0f6964545f commit 9c25fd77397392105990e5af26893b0f6964545f Author: Eugene But <eugenebut@google.com> Date: Wed Apr 04 00:06:51 2018 Fixed status label width for in-progress download. Previously status label was resized by calling sizeToFit. sizeToFit does not play well with autolayout and overrides the existing constraints. This CL creates statusLabelTrailingConstraint which anchors the label to close button or to action button (when download is not in progress and action button is visible). The test was updated to force the view load, so setting up constrains do not fail in the test. Bug: 827641 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2d84d6ba041d85bfd7cee9290c76c56a8f68c8b8 Reviewed-on: https://chromium-review.googlesource.com/988750 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547878} [modify] https://crrev.com/9c25fd77397392105990e5af26893b0f6964545f/ios/chrome/browser/ui/download/download_manager_view_controller.mm
,
Apr 4 2018
,
Apr 10 2018
Verified on iPhone SE(iOS 11.4 beta) and iPhone 5(iOS 10.3.3)in 67.0.3393.0 Canary Download manager Progress UI is not overlapping with close (X) button Link to screenshot: https://drive.google.com/file/d/1Hy0uVKE6zx6vcXtN1sGjI4a003DQacjK/view?usp=sharing |
|||
►
Sign in to add a comment |
|||
Comment 1 by eugene...@chromium.org
, Mar 30 2018Labels: -Restrict-View-Google ReleaseBlock-Stable M-67
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)