Web Animations: Fix bugs with getComputedTiming() => endTime |
|||
Issue descriptionWe currently fail 2/37 tests relating to the endTime from the following WPT test: - external/wpt/web-animations/interfaces/AnimationEffect/getComputedTiming.html FAIL getComputedTiming().endTime for an non-zero duration and negative delay greater than active duration assert_equals: expected 0 but got -1000 FAIL getComputedTiming().endTime for a zero duration and negative delay assert_equals: expected 0 but got -1000 The endTime is computed from the startDelay, ActiveDurationInternal, and endDelay, so this may be somewhat tricky to fix if ActiveDurationInternal has a bug.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55aa8afeb7c99f5aabbe1e44fffcf70f9babd094 commit 55aa8afeb7c99f5aabbe1e44fffcf70f9babd094 Author: Stephen McGruer <smcgruer@chromium.org> Date: Tue Apr 03 13:27:56 2018 Web Animations: give ComputedEffectTiming::endTime a lower bound of 0 The spec defined the calculation clearly, but we had missed the lower bound: https://drafts.csswg.org/web-animations-1/#end-time Bug: 827623 Change-Id: If7ae487d0be09753b2357f1379a2f225a7861bae Reviewed-on: https://chromium-review.googlesource.com/989428 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#547685} [delete] https://crrev.com/9a54951119a1f2493b994e24b0524512c97584e3/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationEffect/getComputedTiming-expected.txt [modify] https://crrev.com/55aa8afeb7c99f5aabbe1e44fffcf70f9babd094/third_party/WebKit/Source/core/animation/AnimationEffect.cpp [modify] https://crrev.com/55aa8afeb7c99f5aabbe1e44fffcf70f9babd094/third_party/WebKit/Source/core/animation/AnimationEffect.h
,
Apr 3 2018
,
Apr 3 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by smcgruer@chromium.org
, Mar 31 2018