Settings icon changes after entering overview mode |
||||||||
Issue descriptionChrome Version: 67.0.3381.0 OS Version: 10525.0.0 What steps will reproduce the problem? 1. Open Settings via the system menu; note blue icon in shelf 2. Enter overview mode 3. Observe icon in shelf What is the expected result? Icon remains blue What happens instead of that? Icons switches to gray favicon
,
Mar 30 2018
How odd. abodenha@, rkc@, is anyone working on overview mode these days?
,
Mar 30 2018
wutao@ has been looking at overview mode.
,
Mar 30 2018
+sammiequon@, maybe you know where in the overview mode we update the setting's icon?
,
Mar 30 2018
this was probably caused by my change. i'll take a look soon.
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e7dcc3d11a342e2a82b9a0f3a038afe1a7a8cc2 commit 3e7dcc3d11a342e2a82b9a0f3a038afe1a7a8cc2 Author: Sammie Quon <sammiequon@google.com> Date: Wed Apr 04 20:20:54 2018 overview: Display the correct settings icon in overview. Previously the settings icon would have its own icon set, but entering overview would change its icon to the favicon. Introduce a new window property kHasOverviewIcon which apps that do not need the favicon would set to true (currently only know to be settings). Test: manual Bug: 827619 Change-Id: I9ef99a7491ca3e3513a883c1d84e3e48894ae81a Reviewed-on: https://chromium-review.googlesource.com/991260 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#548180} [modify] https://crrev.com/3e7dcc3d11a342e2a82b9a0f3a038afe1a7a8cc2/chrome/browser/ui/ash/launcher/settings_window_observer.cc [modify] https://crrev.com/3e7dcc3d11a342e2a82b9a0f3a038afe1a7a8cc2/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc [modify] https://crrev.com/3e7dcc3d11a342e2a82b9a0f3a038afe1a7a8cc2/ui/aura/client/aura_constants.cc [modify] https://crrev.com/3e7dcc3d11a342e2a82b9a0f3a038afe1a7a8cc2/ui/aura/client/aura_constants.h
,
Apr 4 2018
Issue 827596 has been merged into this issue.
,
Apr 4 2018
,
Apr 16 2018
10575.3.0, 67.0.3396.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tbuck...@chromium.org
, Mar 30 2018