[MacViews-Browser] Right Command key triggers context menu when MacViews text input has focus |
||||
Issue descriptionChrome Version: canary 67.0.3384.0 OS: macOS 10.13.4 17E199 Focus the Omnibox and press the right Command key. I get a context menu popping up right at the Omnibox, with these options: Look up “selection” (if there’s anything selected) - Undo Cut Copy Paste Paste and Search Delete - Select All - Edit Search Engines… - Speech > Writing Direction > Services > (if there’s anything selected) This is the same contextual menu that you get when right-clicking the Omnibox. This only happens with the right Command key. The left Command key is fine. I hit this frequently when using Command-L to focus the Omnibox, which I do all the time. Apparently I typically use the one-handed Right-Command-L. I don’t experience this on 10.12.6 16G1314 with the same Chrome version. I don’t experience this with chrome://flags/#views-browser-windows disabled.
,
Mar 30 2018
You can see this on the litterbox right now if you need a hands-on repro.
,
Mar 30 2018
I see this in the Find and Bookmark panels too, so I’m broadening the summary. (Try RightCommand-F.)
,
Mar 30 2018
I think this is probably https://chromium-review.googlesource.com/c/chromium/src/+/986280, no problem reproing. Just waiting a for a build.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fe342852d18fd0ed4b7b725cef99ac0fc61950c commit 0fe342852d18fd0ed4b7b725cef99ac0fc61950c Author: Leonard Grey <lgrey@chromium.org> Date: Tue Apr 03 20:40:19 2018 MacViews: don't trigger a context menu from right command key The right command key shares a key code with the windows context menu key. For key event purposes, we don't want to collapse it together with the left command key in case users have remapped it. Instead, disable the entire keyboard context menu code path, since neither of those shortcuts should work on Mac. Bug: 827618 Change-Id: I05123bde9cd43cf5ba01aaf33d406d8300cbe27b Reviewed-on: https://chromium-review.googlesource.com/988392 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547818} [modify] https://crrev.com/0fe342852d18fd0ed4b7b725cef99ac0fc61950c/ui/views/widget/root_view.cc [modify] https://crrev.com/0fe342852d18fd0ed4b7b725cef99ac0fc61950c/ui/views/widget/root_view_unittest.cc
,
Apr 4 2018
,
Apr 6 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by lgrey@chromium.org
, Mar 30 2018Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)