New issue
Advanced search Search tips

Issue 827613 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 772407



Sign in to add a comment

Web Animations: Fix bugs with getComputedTiming() => localTime

Project Member Reported by smcgruer@chromium.org, Mar 30 2018

Issue description

We currently fail 1/2 tests relating to the localTime in the following WPT:

 - external/wpt/web-animations/timing-model/animation-effects/local-time.html

For some reason the localTime is being reported as null, when it should be a numeric value. This should be investigated and fixed.
 
Blocking: 772407
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02de1dcf4f6ace6334e30574427f10709afc6d43

commit 02de1dcf4f6ace6334e30574427f10709afc6d43
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue Apr 03 14:36:37 2018

Web Animations: Properly report ComputedEffectTime::localTime

The localTime should still be reported when the timing is not in effect.

Bug:  827613 
Change-Id: I3ed29988ed0869a5261e0d756f7fbc94c24f3d4c
Reviewed-on: https://chromium-review.googlesource.com/989655
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547699}
[delete] https://crrev.com/e75bffaa4b84cd9327feed8d15214c4d6c6516a0/third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/animation-effects/local-time-expected.txt
[modify] https://crrev.com/02de1dcf4f6ace6334e30574427f10709afc6d43/third_party/WebKit/Source/core/animation/AnimationEffect.cpp
[modify] https://crrev.com/02de1dcf4f6ace6334e30574427f10709afc6d43/third_party/WebKit/Source/core/animation/AnimationEffect.h

Owner: smcgruer@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment