MacViews: Theme support |
||||
Issue descriptionhttps://chrome.google.com/webstore/detail/glossy-blue/nheaocaplknjkpcnbadlgfpdfjaabiml The theme is "glossy blue". In the top half of the tab strip, the lighter blue area should be a solid strip, not a repeating set of quarter-circles.
,
Apr 17 2018
,
Apr 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/289ea282e986808f3698a7d3f92296fa04a40a41 commit 289ea282e986808f3698a7d3f92296fa04a40a41 Author: Leonard Grey <lgrey@chromium.org> Date: Wed Apr 18 15:39:44 2018 MacViews: Don't tile theme overlay image Bug: 827604 Change-Id: I67b0478de52e7f5bf4bd659afc5b305407072ee3 Reviewed-on: https://chromium-review.googlesource.com/1015514 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551688} [modify] https://crrev.com/289ea282e986808f3698a7d3f92296fa04a40a41/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
,
Apr 18 2018
I messed up my bug line, but also: https://chromium-review.googlesource.com/c/chromium/src/+/1015515 I'll do exhaustive testing before I close this, but I think this is fixed by these two changes.
,
Apr 20 2018
Tested with the following themes (taken from an RVG bug): - https://chrome.google.com/webstore/detail/morpheon-dark/mafbdhjdkjnoafhfelkjpchpaepjknad - https://chrome.google.com/webstore/detail/dark-grey-with-orange-hig/iiimckfhccecppknoingmkhomknkjolb - https://chrome.google.com/webstore/detail/material-incognito-light/necpbhkfondbpbloppmkjpdkdimldobc - https://chrome.google.com/webstore/detail/yellow-high-contrast-chro/mcmhplmmglgnjmjlengbgdjeopmihbcl - https://chrome.google.com/webstore/detail/bob-marley/alpnhingmddeadgmgjbfefmaanaeifak - https://chrome.google.com/webstore/detail/puppy-love/phckohpodbhmbipipacegdpdnedfclei - https://chrome.google.com/webstore/detail/dots/gliedaffibdnbhbiaolgkdhhfbjgmhgi - https://chrome.google.com/webstore/detail/quilt/ofholagheebdhalaonjopcfcedggjooo
,
May 4 2018
Able to reproduce this issue on Mac OS 10.12.6 on the build without fix 67.0.3396.0 and the issue is fixed on the latest Canary 68.0.3419.0 by following the steps given in the original comment. By enabling #views-browser-windows flag, adding the theme 'glossy blue', can observe that the top half of the tab strip is solid strip and not a repeating set of quarter-circles. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks.. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ellyjo...@chromium.org
, Apr 9 2018Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)
Summary: MacViews: Theme support (was: Theme doesn't display properly.)