New issue
Advanced search Search tips

Issue 827602 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.5%-89.6% regression in media.mobile at 546463:546523

Project Member Reported by liberato@google.com, Mar 30 2018

Issue description

this probably won't result in a good bisect, but it looks like it became noisy enough that it's worth a try.

might also have returned to normal recently, but not enough data to tell yet.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 30 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=827602

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=bb42189d84253c08c22fe70bdfd17ece28019dbc8595f67fc69da46d745cee26


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 31 2018

Cc: primiano@chromium.org dpranke@chromium.org mlamouri@chromium.org fdoray@chromium.org agrieve@chromium.org dcheng@chromium.org ssid@chromium.org
Owner: ssid@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/15ddff07440000

Revert "Android: Add code to parse the CFI info added to the apk" by fdoray@chromium.org
https://chromium.googlesource.com/chromium/src/+/88328b6800f987ba9f532842862021cb48875618

Revert "Enable extracting unwind table on official builds without channel" by agrieve@chromium.org
https://chromium.googlesource.com/chromium/src/+/a2474b6490ea9cfda76528059fbf23369e7d281f

Do not change media notification icon multiple times by ssid@chromium.org
https://chromium.googlesource.com/chromium/src/+/a91837ee530b963d208e9f08f5a657e649a5323e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by ssid@chromium.org, Mar 31 2018

Cc: -agrieve@chromium.org -dpranke@chromium.org -dcheng@chromium.org -fdoray@chromium.org -primiano@chromium.org
hm it's mostly the media icon CL:
https://chromium.googlesource.com/chromium/src/+/a91837ee530b963d208e9f08f5a657e649a5323e

Comment 5 by ssid@chromium.org, Apr 6 2018

Cc: johnchen@chromium.org crouleau@chromium.org
+media benchmark owners. I ran this test locally with and without the CL. I cannot reproduce the regression running locally on nexus 5.

For both cases the time to start was ~110ms. The benchmark graphs shows it regressed from 110 to ~200ms.

I ran on ChromePublic.apk with gn args:
ffmpeg_branding = "Chrome"
is_chrome_branded = true
is_component_build = false
is_debug = false
is_official_build = true
proprietary_codecs = true
symbol_level = 1
target_cpu = "arm"
target_os = "android"
use_goma = true

Comment 6 by ssid@chromium.org, Apr 6 2018

Actually I think I figured the issue. It was just timing difference because I made the notification async.. I will fix it.
Cc: -crouleau@chromium.org -johnchen@chromium.org
Great. Feel free to follow up with liberato@ with questions.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42ffcfbbe189e6395e799657c4e6ce163a4edc22

commit 42ffcfbbe189e6395e799657c4e6ce163a4edc22
Author: Siddhartha <ssid@chromium.org>
Date: Fri Apr 20 22:53:07 2018

Media notification: If the current tab does not have favicon, don't try to fetch

If a page does not have any favicon, do not try to fetch an icon from
large icon bridge and wait for callback to update the notification icon.
We know if the page has favicon or not by tracking if onFaviconUpdated
was ever called.

BUG= 827602 

Change-Id: I3356470ca7088871540360621ee3140a3304621b
Reviewed-on: https://chromium-review.googlesource.com/1000314
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552506}
[modify] https://crrev.com/42ffcfbbe189e6395e799657c4e6ce163a4edc22/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/42ffcfbbe189e6395e799657c4e6ce163a4edc22/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationFaviconTest.java

Comment 9 by ssid@chromium.org, Apr 24 2018

Status: Fixed (was: Assigned)
Most graphs came down except some stories on youtube seem to be disabled / not running. So, can't verify.

Sign in to add a comment