Extension functions are using the wrong histograms |
||
Issue descriptionIt looks like some extension functions are using the wrong histogram values, which will mess up our counts of the function calls. We should fix this, and add some verification.
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fad03c4c23289ea297f8bd54c3a93826ad0f98d0 commit fad03c4c23289ea297f8bd54c3a93826ad0f98d0 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 06 03:21:55 2018 [Extensions] Guarantee API functions have unique histogram values The histogram values for an extension function are used to report API call activity and related metrics for extension functions. Each extension function should have a unique histogram value, but some of them were erroneously copy-pasted. This leads to incorrect metrics, both with not reporting one function and over-reporting another. Fix the instances where the histogram values were duplicated, and add a browser test that ensures each function has a unique histogram value. Bug: 827601 Change-Id: Ic44519ca83fe0cf4b3a1896a16232f6400b6c79d Reviewed-on: https://chromium-review.googlesource.com/988227 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#548654} [modify] https://crrev.com/fad03c4c23289ea297f8bd54c3a93826ad0f98d0/chrome/browser/extensions/api/automation_internal/automation_internal_api.h [modify] https://crrev.com/fad03c4c23289ea297f8bd54c3a93826ad0f98d0/chrome/browser/extensions/api/debugger/debugger_api.h [modify] https://crrev.com/fad03c4c23289ea297f8bd54c3a93826ad0f98d0/chrome/browser/extensions/api/notifications/notifications_api.h [add] https://crrev.com/fad03c4c23289ea297f8bd54c3a93826ad0f98d0/chrome/browser/extensions/extension_function_registration_test.cc [modify] https://crrev.com/fad03c4c23289ea297f8bd54c3a93826ad0f98d0/chrome/test/BUILD.gn [modify] https://crrev.com/fad03c4c23289ea297f8bd54c3a93826ad0f98d0/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/fad03c4c23289ea297f8bd54c3a93826ad0f98d0/extensions/browser/extension_function_registry.h [modify] https://crrev.com/fad03c4c23289ea297f8bd54c3a93826ad0f98d0/tools/metrics/histograms/enums.xml
,
Apr 12 2018
Hopefully this fixed all the instances, and will catch future regressions. |
||
►
Sign in to add a comment |
||
Comment 1 by rdevlin....@chromium.org
, Mar 30 2018