New Print Preview close buttons missing |
|||||
Issue descriptionChrome Version: 67.0.3381.1 (Official Build) dev (64-bit) OS: Win10 and Linux, have not tested others. What steps will reproduce the problem? (1) Enable new print preview using --enable-features=NewPrintPreview or chrome://flags. (2) Ctrl + P on any page to open print preview (3) Click "Change" button to change printer What is the expected result? Destinations dialog has a close button in top right corner What happens instead? Close button is missing Notes - Also applies to the Advanced Settings dialog. - This works on Chrome Beta (66.0.3359.66) - Bisected to https://chromium.googlesource.com/chromium/src/+log/d123a43f7c147b640799aa29c20f80c525dc9a51..b6477fef9acbe00a3e8b58b6963b518b57575ed3 Suspecting https://crrev.com/b6477fef9acbe00a3e8b58b6963b518b57575ed3 since it changes the close button in cr_dialog, so cc-ing hcarmona@ and dpapad@.
,
Apr 4 2018
,
Apr 11 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41bb3451f6aacd0969b87ef30701ed9410d399db commit 41bb3451f6aacd0969b87ef30701ed9410d399db Author: rbpotter <rbpotter@chromium.org> Date: Fri Apr 13 15:00:45 2018 Print Preview Componentization: Fix close buttons Make the close buttons appear again in the Print Preview cr-dialogs. Bug: 827579 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64999ea9e56ba34509040294dc7178c47facadd3 Reviewed-on: https://chromium-review.googlesource.com/1007626 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550620} [modify] https://crrev.com/41bb3451f6aacd0969b87ef30701ed9410d399db/chrome/browser/resources/print_preview/new/search_dialog_css.html [modify] https://crrev.com/41bb3451f6aacd0969b87ef30701ed9410d399db/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
,
Apr 13 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41bb3451f6aacd0969b87ef30701ed9410d399db commit 41bb3451f6aacd0969b87ef30701ed9410d399db Author: rbpotter <rbpotter@chromium.org> Date: Fri Apr 13 15:00:45 2018 Print Preview Componentization: Fix close buttons Make the close buttons appear again in the Print Preview cr-dialogs. Bug: 827579 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64999ea9e56ba34509040294dc7178c47facadd3 Reviewed-on: https://chromium-review.googlesource.com/1007626 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550620} [modify] https://crrev.com/41bb3451f6aacd0969b87ef30701ed9410d399db/chrome/browser/resources/print_preview/new/search_dialog_css.html [modify] https://crrev.com/41bb3451f6aacd0969b87ef30701ed9410d399db/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpa...@chromium.org
, Mar 30 2018Status: Available (was: Untriaged)