Web Animations: Fix bugs with getComputedTiming() => currentIteration |
|
Issue descriptionWe currently fail 10/51 tests relating to the current iteration from the following WPT test: - external/wpt/web-animations/timing-model/animation-effects/current-iteration.html The currentIteration is computed in CalculateCurrentIteration in TimingCalculations.h, and is only used for getComputedTiming so the broken cases should hopefully be easy to resolve.
,
Jun 15 2018
There is an in-progress CL for this at https://chromium-review.googlesource.com/c/chromium/src/+/989297, but it turned out to be much harder than expected. The two main issues appears to be floating point rounding errors (due to issue 737867) and some DCHECKs triggering because current_iteration turns out to be nan: [1:1:0615/141402.563272:FATAL:timing_calculations.h(299)] Check failed: current_iteration >= 0 (nan vs. 0) |
|
►
Sign in to add a comment |
|
Comment 1 by smcgruer@chromium.org
, Mar 31 2018