New issue
Advanced search Search tips

Issue 827575 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug


Participants' hotlists:
Hotlist-1


Sign in to add a comment

Test AuthenticatorImpl with even more origin-rpId and origin-appId pairs

Project Member Reported by engedy@chromium.org, Mar 30 2018

Issue description

We should think of whether any important test cases are missing for origin-appId pairs and, if any, add them to |kAppIdCases|.

We should also consider splitting off |kValidAppIdCases| from it, and merging the rest into |kInvalidRelyingPartyTestCases| to have some origin-rpId test cases with invalid, URL-formatted rpIds too, if for nothing else, then for the case of compromised renderers.
 

Comment 1 by engedy@chromium.org, Mar 30 2018

Description: Show this description
Related: crbug.com/803414

Comment 3 by engedy@chromium.org, Mar 31 2018

Labels: Hotlist-WebAuthnFixit
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ace033f995bd302e558c4f00cba5010420d576

commit a4ace033f995bd302e558c4f00cba5010420d576
Author: Adam Langley <agl@chromium.org>
Date: Wed Apr 04 20:14:27 2018

webauthn: add some more AppId test cases.

Change-Id: Iaeddffa11bdf0079b4c027356d3bc8d47f366bf1
Bug:  827575 
Reviewed-on: https://chromium-review.googlesource.com/982633
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548176}
[modify] https://crrev.com/a4ace033f995bd302e558c4f00cba5010420d576/content/browser/webauth/authenticator_impl_unittest.cc

Can we close this bug out?

Comment 6 by agl@chromium.org, Jun 5 2018

Status: Fixed (was: Started)

Sign in to add a comment