New issue
Advanced search Search tips

Issue 827573 link

Starred by 1 user
Status: Fixed
Owner:
smcgruer@chromium.org
Closed: Apr 2018
Cc:
smcgruer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 772407



Sign in to add a comment

Web Animations: Bugs in procedure to process a keyframes argument

Project Member Reported by smcgruer@chromium.org, Mar 30 2018 
Currently we fail a handful of the WPT tests relating to processing a keyframes argument:

  - external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html

FAIL A list of values returned from a custom iterator should be ignored Failed to construct 'KeyframeEffect': Lists of values not permitted in array-form list of keyframes
FAIL Only properties defined directly on keyframes are read assert_equals: properties on ComputedKeyframe #0 should match expected "composite,computedOffset,easing,offset,top" but got "composite,computedOffset,easing,height,left,offset,top"
FAIL Only properties defined directly on property-indexed keyframes are read assert_equals: properties on ComputedKeyframe #0 should match expected "composite,computedOffset,easing,offset,top" but got "composite,computedOffset,easing,left,offset,top"
FAIL Properties are read in ascending order by Unicode codepoint assert_array_equals: property access order property 3, expected "left" but got "marginLeft"

We should fix up these remaining failures in our algorithm implementation.

Comment 1 by smcgruer@chromium.org, Mar 31 2018

Blocking: 772407
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ade0386aa4168b48234bc7f33d30a62140b95ea

commit 0ade0386aa4168b48234bc7f33d30a62140b95ea
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Fri Apr 13 16:39:13 2018

Web Animations: Fix bugs in procedure to process a keyframes argument

There were three minor bugs left in the implementation:

  - We threw on lists-in-custom-iterators instead of just ignoring them.
  - We returned all properties on the keyframe rather than just those
    defined on the keyframe itself (e.g. we would include prototype
    properties, against spec).
  - We didn't access the properties in ascending unicode order.

Bug:  827573 
Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
Reviewed-on: https://chromium-review.googlesource.com/989261
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550641}
[delete] https://crrev.com/d014653a8c07c2ad6e4899d401037a313b4ed095/third_party/WebKit/LayoutTests/animations/stability/keyframe-iteration-exception-crash.html
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/WebKit/LayoutTests/animations/web-animations/element-animate-iterable-keyframes.html
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[delete] https://crrev.com/d014653a8c07c2ad6e4899d401037a313b4ed095/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html
[delete] https://crrev.com/d014653a8c07c2ad6e4899d401037a313b4ed095/third_party/WebKit/LayoutTests/fast/dom/dictionary-member-get-throws.html
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/dictionary.cc
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/dictionary.h
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/dictionary_test.cc
[rename] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/script_iterator.cc
[rename] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/script_iterator.h
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/core/animation/effect_input.cc
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/core/testing/dictionary_test.cc

Comment 3 by smcgruer@chromium.org, Apr 13 2018

Status: Fixed (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12

commit c249e29de3f6a5e87da8ef2ca6d68c3e1240db12
Author: Avi Drissman <avi@chromium.org>
Date: Fri Apr 13 19:42:19 2018

Revert "Web Animations: Fix bugs in procedure to process a keyframes argument"

This reverts commit 0ade0386aa4168b48234bc7f33d30a62140b95ea.

Reason for revert:
Unexpected Failures:
* bindings/sequence-type.html
* custom-elements/spec/define-element.html
* external/wpt/custom-elements/CustomElementRegistry.html

on 
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/

Speculatively reverting this to see if it's the cause.

Original change's description:
> Web Animations: Fix bugs in procedure to process a keyframes argument
> 
> There were three minor bugs left in the implementation:
> 
>   - We threw on lists-in-custom-iterators instead of just ignoring them.
>   - We returned all properties on the keyframe rather than just those
>     defined on the keyframe itself (e.g. we would include prototype
>     properties, against spec).
>   - We didn't access the properties in ascending unicode order.
> 
> Bug:  827573 
> Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
> Reviewed-on: https://chromium-review.googlesource.com/989261
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550641}

TBR=flackr@chromium.org,yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org,smcgruer@chromium.org

Change-Id: I5e8dc0c67599492bd6e90fca4a034e29e334ef88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  827573 
Reviewed-on: https://chromium-review.googlesource.com/1012857
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550721}
[add] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/animations/stability/keyframe-iteration-exception-crash.html
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/animations/web-animations/element-animate-iterable-keyframes.html
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[add] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html
[add] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/fast/dom/dictionary-member-get-throws.html
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary.h
[rename] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary_iterator.cc
[rename] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary_iterator.h
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary_test.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/core/animation/effect_input.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/core/testing/dictionary_test.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d1b59635874df002380287f9e404ca4c3d284fa

commit 1d1b59635874df002380287f9e404ca4c3d284fa
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Sat Apr 14 15:23:06 2018

Reland "Web Animations: Fix bugs in procedure to process a keyframes argument"

This is a reland of 0ade0386aa4168b48234bc7f33d30a62140b95ea

Original change's description:
> Web Animations: Fix bugs in procedure to process a keyframes argument
> 
> There were three minor bugs left in the implementation:
> 
>   - We threw on lists-in-custom-iterators instead of just ignoring them.
>   - We returned all properties on the keyframe rather than just those
>     defined on the keyframe itself (e.g. we would include prototype
>     properties, against spec).
>   - We didn't access the properties in ascending unicode order.
> 
> Bug:  827573 
> Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
> Reviewed-on: https://chromium-review.googlesource.com/989261
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550641}

Bug:  827573 
Change-Id: I6c49fa6ca36db16ecddfb520e0964bd231565a0b
Reviewed-on: https://chromium-review.googlesource.com/1012897
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550895}
[delete] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/third_party/WebKit/LayoutTests/animations/stability/keyframe-iteration-exception-crash.html
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/WebKit/LayoutTests/animations/web-animations/element-animate-iterable-keyframes.html
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[delete] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html
[delete] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/third_party/WebKit/LayoutTests/fast/dom/dictionary-member-get-throws.html
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/dictionary.cc
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/dictionary.h
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/dictionary_test.cc
[rename] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/script_iterator.cc
[rename] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/script_iterator.h
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/core/animation/effect_input.cc
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/core/testing/dictionary_test.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ade0386aa4168b48234bc7f33d30a62140b95ea

commit 0ade0386aa4168b48234bc7f33d30a62140b95ea
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Fri Apr 13 16:39:13 2018

Web Animations: Fix bugs in procedure to process a keyframes argument

There were three minor bugs left in the implementation:

  - We threw on lists-in-custom-iterators instead of just ignoring them.
  - We returned all properties on the keyframe rather than just those
    defined on the keyframe itself (e.g. we would include prototype
    properties, against spec).
  - We didn't access the properties in ascending unicode order.

Bug:  827573 
Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
Reviewed-on: https://chromium-review.googlesource.com/989261
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550641}
[delete] https://crrev.com/d014653a8c07c2ad6e4899d401037a313b4ed095/third_party/WebKit/LayoutTests/animations/stability/keyframe-iteration-exception-crash.html
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/WebKit/LayoutTests/animations/web-animations/element-animate-iterable-keyframes.html
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[delete] https://crrev.com/d014653a8c07c2ad6e4899d401037a313b4ed095/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html
[delete] https://crrev.com/d014653a8c07c2ad6e4899d401037a313b4ed095/third_party/WebKit/LayoutTests/fast/dom/dictionary-member-get-throws.html
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/dictionary.cc
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/dictionary.h
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/dictionary_test.cc
[rename] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/script_iterator.cc
[rename] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/script_iterator.h
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/core/animation/effect_input.cc
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/0ade0386aa4168b48234bc7f33d30a62140b95ea/third_party/blink/renderer/core/testing/dictionary_test.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12

commit c249e29de3f6a5e87da8ef2ca6d68c3e1240db12
Author: Avi Drissman <avi@chromium.org>
Date: Fri Apr 13 19:42:19 2018

Revert "Web Animations: Fix bugs in procedure to process a keyframes argument"

This reverts commit 0ade0386aa4168b48234bc7f33d30a62140b95ea.

Reason for revert:
Unexpected Failures:
* bindings/sequence-type.html
* custom-elements/spec/define-element.html
* external/wpt/custom-elements/CustomElementRegistry.html

on 
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/

Speculatively reverting this to see if it's the cause.

Original change's description:
> Web Animations: Fix bugs in procedure to process a keyframes argument
> 
> There were three minor bugs left in the implementation:
> 
>   - We threw on lists-in-custom-iterators instead of just ignoring them.
>   - We returned all properties on the keyframe rather than just those
>     defined on the keyframe itself (e.g. we would include prototype
>     properties, against spec).
>   - We didn't access the properties in ascending unicode order.
> 
> Bug:  827573 
> Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
> Reviewed-on: https://chromium-review.googlesource.com/989261
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550641}

TBR=flackr@chromium.org,yukishiino@chromium.org,jbroman@chromium.org,haraken@chromium.org,smcgruer@chromium.org

Change-Id: I5e8dc0c67599492bd6e90fca4a034e29e334ef88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  827573 
Reviewed-on: https://chromium-review.googlesource.com/1012857
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550721}
[add] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/animations/stability/keyframe-iteration-exception-crash.html
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/animations/web-animations/element-animate-iterable-keyframes.html
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[add] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html
[add] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/WebKit/LayoutTests/fast/dom/dictionary-member-get-throws.html
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary.h
[rename] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary_iterator.cc
[rename] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary_iterator.h
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/dictionary_test.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/core/animation/effect_input.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/c249e29de3f6a5e87da8ef2ca6d68c3e1240db12/third_party/blink/renderer/core/testing/dictionary_test.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d1b59635874df002380287f9e404ca4c3d284fa

commit 1d1b59635874df002380287f9e404ca4c3d284fa
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Sat Apr 14 15:23:06 2018

Reland "Web Animations: Fix bugs in procedure to process a keyframes argument"

This is a reland of 0ade0386aa4168b48234bc7f33d30a62140b95ea

Original change's description:
> Web Animations: Fix bugs in procedure to process a keyframes argument
> 
> There were three minor bugs left in the implementation:
> 
>   - We threw on lists-in-custom-iterators instead of just ignoring them.
>   - We returned all properties on the keyframe rather than just those
>     defined on the keyframe itself (e.g. we would include prototype
>     properties, against spec).
>   - We didn't access the properties in ascending unicode order.
> 
> Bug:  827573 
> Change-Id: I213ae5b24e1f35d7f28d16625025122950a6ba88
> Reviewed-on: https://chromium-review.googlesource.com/989261
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550641}

Bug:  827573 
Change-Id: I6c49fa6ca36db16ecddfb520e0964bd231565a0b
Reviewed-on: https://chromium-review.googlesource.com/1012897
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550895}
[delete] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/third_party/WebKit/LayoutTests/animations/stability/keyframe-iteration-exception-crash.html
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/WebKit/LayoutTests/animations/web-animations/element-animate-iterable-keyframes.html
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[delete] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001-expected.txt
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/processing-a-keyframes-argument-001.html
[delete] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/third_party/WebKit/LayoutTests/fast/dom/dictionary-member-get-throws.html
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/bindings.gni
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/dictionary.cc
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/dictionary.h
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/dictionary_test.cc
[rename] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/script_iterator.cc
[rename] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/script_iterator.h
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/core/animation/effect_input.cc
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/1d1b59635874df002380287f9e404ca4c3d284fa/third_party/blink/renderer/core/testing/dictionary_test.cc

Comment 9 by smcgruer@chromium.org, May 15 2018

Owner: smcgruer@chromium.org
►

Sign in to add a comment