Web Animations: AnimationPlaybackEvent constructor WPT test fails |
||
Issue descriptionThe following WPT test currently fails because one of evt.currentTime or evt.timelineTime is not null when using the default constructor: - web-animations/interfaces/AnimationPlaybackEvent/constructor.html This should be a quick fix; the AnimationPlaybackEvent::AnimationPlaybackEvent constructor should initialize the values to null not 0.0. It would also be good to switch them to using WTF::Optional for the values.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc4fa433ef22545acfca61e8029c0f7fff8de17c commit cc4fa433ef22545acfca61e8029c0f7fff8de17c Author: Stephen McGruer <smcgruer@chromium.org> Date: Tue Apr 03 15:25:57 2018 Web Animations: Make AnimationPlaybackEvent's members null by default Whilst the code did correctly check whether the members of AnimationPlaybackEventInit were null, the AnimationPlaybackEvent constructor was setting them to 0.0 as a default value, which is incorrect via the spec: https://drafts.csswg.org/web-animations-1/#the-animationplaybackevent-interface This CL also converts the class members to use WTF::Optional to clearly distinguish between them being set and not set. Bug: 827572 Change-Id: I471666a022963dd19f8a74eaebafeeebf4e96c66 Reviewed-on: https://chromium-review.googlesource.com/988339 Reviewed-by: Xida Chen <xidachen@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#547715} [delete] https://crrev.com/f57250877e2eefe4887699bc5e9d8ff9061b8398/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/AnimationPlaybackEvent/constructor-expected.txt [modify] https://crrev.com/cc4fa433ef22545acfca61e8029c0f7fff8de17c/third_party/WebKit/Source/core/events/AnimationPlaybackEvent.cpp [modify] https://crrev.com/cc4fa433ef22545acfca61e8029c0f7fff8de17c/third_party/WebKit/Source/core/events/AnimationPlaybackEvent.h
,
Apr 3 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by smcgruer@chromium.org
, Mar 31 2018