New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827569 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Media Controls VR: Double-tap-to-scrub is easy to trigger by accident - disable in VR

Project Member Reported by beccahughes@chromium.org, Mar 30 2018

Issue description

Double-tap-to-scrub is easy to trigger by accident - disable in VR

(from bug bash)
 
Description: Show this description
Owner: mlamouri@chromium.org
Status: Assigned (was: Available)
I will take this one.
Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75f5cc7272391b1d22d40d2668f4063ec55a1899

commit 75f5cc7272391b1d22d40d2668f4063ec55a1899
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Sat May 26 22:31:21 2018

Media Controls: disable double-tap to scrub in immersive mode.

It is to easy to accidentally trigger the scrubbing otherwise according
to the VR team.

Bug:  827569 
Change-Id: Ia4bf75e389303628f521caf39166e409feb3b66a
Reviewed-on: https://chromium-review.googlesource.com/1071714
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562131}
[add] https://crrev.com/75f5cc7272391b1d22d40d2668f4063ec55a1899/third_party/WebKit/LayoutTests/media/controls/immersive-doubletap.html
[modify] https://crrev.com/75f5cc7272391b1d22d40d2668f4063ec55a1899/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/959cb60f42af1a8413d7fed44fc0ad35cbd89be2

commit 959cb60f42af1a8413d7fed44fc0ad35cbd89be2
Author: Trent Apted <tapted@chromium.org>
Date: Mon May 28 02:38:58 2018

Revert "Media Controls: disable double-tap to scrub in immersive mode."

This reverts commit 75f5cc7272391b1d22d40d2668f4063ec55a1899.

Reason for revert: Suspect for WebKit Linux Trusty Leak failures since
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19394

Unexpected Failures:
* media/controls/immersive-doubletap.html
* virtual/exotic-color-space/images/feature-policy-max-downscaling-image-styles.html
* virtual/new-remote-playback-pipeline/media/controls/immersive-doubletap.html
* virtual/video-surface-layer/media/controls/immersive-doubletap.html

Original change's description:
> Media Controls: disable double-tap to scrub in immersive mode.
> 
> It is to easy to accidentally trigger the scrubbing otherwise according
> to the VR team.
> 
> Bug:  827569 
> Change-Id: Ia4bf75e389303628f521caf39166e409feb3b66a
> Reviewed-on: https://chromium-review.googlesource.com/1071714
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562131}

TBR=mlamouri@chromium.org,beccahughes@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  827569 
Change-Id: I23086a535747900aad1237b0c3dcd34fcf3b1ac9
Reviewed-on: https://chromium-review.googlesource.com/1074568
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562166}
[delete] https://crrev.com/577963aecb20afb7be442fe782d9508b0a9b075e/third_party/WebKit/LayoutTests/media/controls/immersive-doubletap.html
[modify] https://crrev.com/959cb60f42af1a8413d7fed44fc0ad35cbd89be2/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc

Status: Started (was: Fixed)
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02183cca876790e3e36eac837c6fd9e206e33c12

commit 02183cca876790e3e36eac837c6fd9e206e33c12
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Nov 27 23:32:05 2018

Media Controls: disable double-tap to scrub in immersive mode.

It is to easy to accidentally trigger the scrubbing otherwise according
to the VR team.

Bug:  827569 
Change-Id: I55236c36c4759e64eea8f3ae2a49de452f95fc45
Reviewed-on: https://chromium-review.googlesource.com/1071714
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562131}
Reviewed-on: https://chromium-review.googlesource.com/c/1076374
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611412}
[modify] https://crrev.com/02183cca876790e3e36eac837c6fd9e206e33c12/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[add] https://crrev.com/02183cca876790e3e36eac837c6fd9e206e33c12/third_party/blink/web_tests/media/controls/immersive-doubletap.html

Status: Fixed (was: Started)

Sign in to add a comment