Remove DownloadFeedbackDialogView. Upload for existing SBER's only |
||||||||||
Issue descriptionThe opt-in rate is super low on this dialog, and it complicates the logic on when we upload a binary that the server-side asks for. Let's remove it, and upload as soon as the download is complete, if the user has already opted in to SBER. This will increase the coverage of download feedback by removing the corner cases where we don't upload when we should. conversation: https://chromium-review.googlesource.com/c/chromium/src/+/974441/10//COMMIT_MSG#11
,
Apr 5 2018
assigning to SB team
,
Apr 6 2018
,
Apr 6 2018
,
Jun 8 2018
On leave, unassigning for re-triage.
,
Jun 15 2018
,
Aug 2
,
Sep 12
This may be relevant to any refactoring work in download protection, so cc:drubery.
,
Sep 24
This looks like a pretty straightforward refactoring, so I'll do it now.
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fa932a81e85290c925b37ac001992969dadde21 commit 0fa932a81e85290c925b37ac001992969dadde21 Author: Daniel Rubery <drubery@chromium.org> Date: Tue Sep 25 19:03:51 2018 Remove DownloadFeedbackDialogView The opt-in on DownloadFeedbackDialogView is very low, so remove it. At the same time, refactor logic for reporting. The safe browsing preferences are now checked within the DownloadProtectionService. Bug: 827567 Change-Id: I1bed2d912b53504246f21a803f0095cd15ead125 Reviewed-on: https://chromium-review.googlesource.com/1238563 Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#594039} [modify] https://crrev.com/0fa932a81e85290c925b37ac001992969dadde21/chrome/browser/download/download_browsertest.cc [modify] https://crrev.com/0fa932a81e85290c925b37ac001992969dadde21/chrome/browser/safe_browsing/download_protection/download_protection_service.cc [modify] https://crrev.com/0fa932a81e85290c925b37ac001992969dadde21/chrome/browser/safe_browsing/download_protection/download_protection_service.h [modify] https://crrev.com/0fa932a81e85290c925b37ac001992969dadde21/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc [modify] https://crrev.com/0fa932a81e85290c925b37ac001992969dadde21/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/a5cdd6fb07e2e16b0a9387149570638528962f5b/chrome/browser/ui/views/download/download_feedback_dialog_view.cc [delete] https://crrev.com/a5cdd6fb07e2e16b0a9387149570638528962f5b/chrome/browser/ui/views/download/download_feedback_dialog_view.h [modify] https://crrev.com/0fa932a81e85290c925b37ac001992969dadde21/chrome/browser/ui/views/download/download_item_view.cc
,
Sep 25
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by nparker@chromium.org
, Mar 30 2018