New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827559 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Play/pause icon is too small in relation to backing circle (see spec)

Project Member Reported by beccahughes@chromium.org, Mar 30 2018

Issue description

Play/pause icon is too small in relation to backing circle (see spec)

(from bug bash)
 
Owner: beccahughes@chromium.org
Status: Started (was: Available)
Screenshot from pending CL attached
Screenshot from 2018-04-06 15-40-18.png
4.6 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/726e15da63521fc5cbb6cae1601b4898fc9bfc59

commit 726e15da63521fc5cbb6cae1601b4898fc9bfc59
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Apr 10 01:52:45 2018

Media Controls: Increase play/pause icon size

The spec icons were 24px but they had an internal margin of 2px.
The standard MD vector icons that we use are 24px but have an
unaccounted margin of 5px. Increasing the size by 6px will
compensate for 3px of that extra margin and now match the spec.

BUG= 827559 

Change-Id: I3d57f5a8b06ae20cf8b34d57fbb63ca4067eb0f7
Reviewed-on: https://chromium-review.googlesource.com/1000528
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549372}
[modify] https://crrev.com/726e15da63521fc5cbb6cae1601b4898fc9bfc59/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Started)

Sign in to add a comment