New issue
Advanced search Search tips

Issue 827551 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Hotlist-1


Sign in to add a comment

Miscellaneous clean-ups around CBORReader

Project Member Reported by engedy@chromium.org, Mar 30 2018

Issue description

Improve code readability and robustness.
 

Comment 1 by engedy@chromium.org, Mar 31 2018

Labels: Hotlist-WebAuthnFixit
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/565f5a3f82c45eb2a0da9d56696dbd5e00d8938b

commit 565f5a3f82c45eb2a0da9d56696dbd5e00d8938b
Author: Adam Langley <agl@chromium.org>
Date: Mon Apr 02 22:53:46 2018

cbor: only need to check map value order.

If we enforce that each new map value is greater than the previous one
then that ensures that no duplicates are allowed without doing a lookup
for every insert.

Bug:  827551 
Change-Id: Idcc24b1070cc1707362f37a7f76198053882148a
Reviewed-on: https://chromium-review.googlesource.com/982610
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547546}
[modify] https://crrev.com/565f5a3f82c45eb2a0da9d56696dbd5e00d8938b/components/cbor/cbor_reader.cc
[modify] https://crrev.com/565f5a3f82c45eb2a0da9d56696dbd5e00d8938b/components/cbor/cbor_reader.h
[modify] https://crrev.com/565f5a3f82c45eb2a0da9d56696dbd5e00d8938b/components/cbor/cbor_reader_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc341a3c395d3b6424081b97da4470350ea6db14

commit dc341a3c395d3b6424081b97da4470350ea6db14
Author: Adam Langley <agl@chromium.org>
Date: Wed Apr 04 17:23:41 2018

cbor: ensure that error codes are set iff parsing fails.

Bug:  827551 
Change-Id: I134199ca4538f469fc29d0b315a9e36f72e8df80
Reviewed-on: https://chromium-review.googlesource.com/982611
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548108}
[modify] https://crrev.com/dc341a3c395d3b6424081b97da4470350ea6db14/components/cbor/cbor_reader.cc
[modify] https://crrev.com/dc341a3c395d3b6424081b97da4470350ea6db14/components/cbor/cbor_reader.h

Can we close this bug out?

Comment 5 by agl@chromium.org, Today (18 hours ago)

Status: Fixed (was: Started)

Sign in to add a comment