Miscellaneous clean-ups around CBORReader |
||
Issue descriptionImprove code readability and robustness.
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/565f5a3f82c45eb2a0da9d56696dbd5e00d8938b commit 565f5a3f82c45eb2a0da9d56696dbd5e00d8938b Author: Adam Langley <agl@chromium.org> Date: Mon Apr 02 22:53:46 2018 cbor: only need to check map value order. If we enforce that each new map value is greater than the previous one then that ensures that no duplicates are allowed without doing a lookup for every insert. Bug: 827551 Change-Id: Idcc24b1070cc1707362f37a7f76198053882148a Reviewed-on: https://chromium-review.googlesource.com/982610 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547546} [modify] https://crrev.com/565f5a3f82c45eb2a0da9d56696dbd5e00d8938b/components/cbor/cbor_reader.cc [modify] https://crrev.com/565f5a3f82c45eb2a0da9d56696dbd5e00d8938b/components/cbor/cbor_reader.h [modify] https://crrev.com/565f5a3f82c45eb2a0da9d56696dbd5e00d8938b/components/cbor/cbor_reader_unittest.cc
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc341a3c395d3b6424081b97da4470350ea6db14 commit dc341a3c395d3b6424081b97da4470350ea6db14 Author: Adam Langley <agl@chromium.org> Date: Wed Apr 04 17:23:41 2018 cbor: ensure that error codes are set iff parsing fails. Bug: 827551 Change-Id: I134199ca4538f469fc29d0b315a9e36f72e8df80 Reviewed-on: https://chromium-review.googlesource.com/982611 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#548108} [modify] https://crrev.com/dc341a3c395d3b6424081b97da4470350ea6db14/components/cbor/cbor_reader.cc [modify] https://crrev.com/dc341a3c395d3b6424081b97da4470350ea6db14/components/cbor/cbor_reader.h
,
Jun 5 2018
Can we close this bug out?
,
Today
(18 hours ago)
|
||
►
Sign in to add a comment |
||
Comment 1 by engedy@chromium.org
, Mar 31 2018