ToolsSanityTest.AsanCorruptHeapBlock fails on win asan bots |
||
Issue descriptionhttps://chromium-review.googlesource.com/c/chromium/src/+/980912 added ToolsSanityTest.AsanCorruptHeapBlock to the asan bot. It doesn't actually pass: https://ci.chromium.org/buildbot/chromium.clang/CrWinAsanCov/418 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FCrWinAsanCov%2F418%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests%2F0%2Flogs%2FToolsSanityTest.AsanCorruptHeapBlock%2F0 This calls this code: https://cs.chromium.org/chromium/src/base/debug/asan_invalid_access.cc?type=cs&q=AsanCorruptHeapBlock&sq=package:chromium&l=28 Maybe clang is smart enough to optimize away the invalid access or something. In the meantime we should disable that test again to green things up.
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/597be546a198483d3ce3316de6c86bec6d75043b commit 597be546a198483d3ce3316de6c86bec6d75043b Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Wed Apr 04 15:44:04 2018 Disable ASAN heap corruption unittests. The ASAN runtime doesn't detect heap corruption from uninstrumented code, and so the test fails to die. Bug: 818747, 827548 Change-Id: Ic8bd73c375887b3cf1de79b6fe5838cd31efa426 Reviewed-on: https://chromium-review.googlesource.com/992572 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548074} [modify] https://crrev.com/597be546a198483d3ce3316de6c86bec6d75043b/base/tools_sanity_unittest.cc
,
Apr 5 2018
Greened up - closing this one. |
||
►
Sign in to add a comment |
||
Comment 1 by siggi@chromium.org
, Apr 3 2018