New issue
Advanced search Search tips

Issue 827546 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

new mini_installer_tests target doesn't actually work

Project Member Reported by thakis@chromium.org, Mar 30 2018

Issue description

We now have a mini_installer_tests target as of https://chromium-review.googlesource.com/c/chromium/src/+/969955

It's currently only hooked up on the Win 10 Fast Ring bot (https://ci.chromium.org/buildbot/chromium.fyi/Win%2010%20Fast%20Ring/ ; cf https://cs.chromium.org/search/?q=mini_installer_tests+file:buildbot&sq=package:chromium&type=cs). It's failing there with 

Set PYTHONPATH: E:\b\rr\tmph6_qjr\rw\scripts;E:\b\rr\tmph6_qjr\rw\site_config;E:\b\rr\tmph6_qjr\rw\third_party;E:\b\rr\tmph6_qjr\rw\third_party\buildbot_8_4p1;E:\b\rr\tmph6_qjr\rw\third_party\buildbot_slave_8_4;E:\b\rr\tmph6_qjr\rw\third_party\coverage-3.7.1;E:\b\rr\tmph6_qjr\rw\third_party\decorator_3_3_1;E:\b\rr\tmph6_qjr\rw\third_party\google_api_python_client;E:\b\rr\tmph6_qjr\rw\third_party\httplib2\python2;E:\b\rr\tmph6_qjr\rw\third_party\infra_libs;E:\b\rr\tmph6_qjr\rw\third_party\jinja2;E:\b\rr\tmph6_qjr\rw\third_party\markupsafe;E:\b\rr\tmph6_qjr\rw\third_party\oauth2client;E:\b\rr\tmph6_qjr\rw\third_party\pyasn1;E:\b\rr\tmph6_qjr\rw\third_party\pyasn1-modules;E:\b\rr\tmph6_qjr\rw\third_party\python-rsa;E:\b\rr\tmph6_qjr\rw\third_party\requests_2_10_0;E:\b\rr\tmph6_qjr\rw\third_party\setuptools-0.6c11;E:\b\rr\tmph6_qjr\rw\third_party\sqlalchemy_0_7_1;E:\b\rr\tmph6_qjr\rw\third_party\sqlalchemy_migrate_0_7_1;E:\b\rr\tmph6_qjr\rw\third_party\tempita_0_5;E:\b\rr\tmph6_qjr\rw\third_party\twisted_10_2;E:\b\rr\tmph6_qjr\rw\third_party\uritemplate;E:\b\rr\tmph6_qjr\rw\third_party\site-packages;E:\b\rr\tmph6_qjr\rw\scripts\tools;E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\python27.zip;E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\DLLs;E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib;E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib\plat-win;E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib\lib-tk;E:\b\depot_tools\win_tools-2_7_6_bin\python\bin
[Running on builder: "Win 10 Fast Ring"]
Traceback (most recent call last):
  File "E:\b\rr\tmph6_qjr\rw\scripts\slave\runtest.py", line 1618, in <module>
    sys.exit(main())
  File "E:\b\rr\tmph6_qjr\rw\scripts\slave\runtest.py", line 1583, in main
    result = _MainWin(options, args, extra_env)
  File "E:\b\rr\tmph6_qjr\rw\scripts\slave\runtest.py", line 1165, in _MainWin
    raise chromium_utils.PathNotFound('Unable to find %s' % test_exe_path)
common.chromium_utils.PathNotFound: Unable to find E:\b\c\builder\Win_10_Fast_Ring\src\out\Release_x64\mini_installer_tests.exe
step returned non-zero exit code: 1


I also tried to use it in https://chromium-review.googlesource.com/#/c/986679/ thinking that this is how I'd run the installer tests on the bots (it isn't; calling steps.MiniInstallerTest() from the recipe is how I do this: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_win.py?type=cs&q=MiniInstallerTest&sq=package:chromium&l=45), and this target just comes back purple: https://ci.chromium.org/buildbot/chromium.clang/CrWinClang/3179 / https://chromium-swarm.appspot.com/task?id=3c8f66d03a55b410&refresh=10&show_raw=1

test_installer.py: error: unrecognized arguments: --test-launcher-summary-output=e:\b\swarm_slave\w\iobgp86y\output.json


It'd be cool if the target worked, and if we could then replace the current recipe-side execution of installer tests with the src-side configured one.
 

Comment 1 by mmeade@chromium.org, Mar 30 2018

Status: Started (was: Untriaged)
This is still a work in progress, but we're close. It very much is the goal to get rid of the build-side step and run this like we do the other tests.
https://crrev.com/c/988260 should fix this, it was mostly a test configuration error.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c232a8c760a690cdfc282cdc39e1dd2192e47d6

commit 4c232a8c760a690cdfc282cdc39e1dd2192e47d6
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Apr 03 21:52:03 2018

Move mini_installer_tests to Win10 as experiment.

This moves the new isolated-script-based installer test to run on
Win10 as an experiment, rather than running locally on Win Fast
Ring (also fixing the gtest misconfiguration).

No-Try: true
Bug:  827546 

Change-Id: I687a763d81c7095c88a6c879156ff2043336a863
Reviewed-on: https://chromium-review.googlesource.com/988260
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547843}
[modify] https://crrev.com/4c232a8c760a690cdfc282cdc39e1dd2192e47d6/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/4c232a8c760a690cdfc282cdc39e1dd2192e47d6/testing/buildbot/chromium.win.json
[modify] https://crrev.com/4c232a8c760a690cdfc282cdc39e1dd2192e47d6/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/4c232a8c760a690cdfc282cdc39e1dd2192e47d6/testing/buildbot/waterfalls.pyl

Owner: dpranke@chromium.org
What is the status on this bug?

I'm assigning to Dirk since he has been working on it.

Comment 6 by thakis@chromium.org, Apr 16 2018

I too am curious what the status is here.
I think we can turn this on at 100% but I havne't had time to look at the stats or post the CL. I will try to do that today.
It looks like the test is running fine, so I'm posting a CL To turn this on by default. 

Sorry for the delay :(.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3262c9b296d995160b45d215803fe80f61fededb

commit 3262c9b296d995160b45d215803fe80f61fededb
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Apr 18 18:25:50 2018

Turn mini_installer_tests on by default on Win10.

This makes mini_installer_tests non-experimental and adds them
to the CQ on win10_chromium_x64_rel_ng.

R=grt@chromium.org, mmeade@chromium.org, sergeyberezin@chromium.org
BUG= 827546 

Change-Id: I742d7003dd706949ee73e8e4febaa91b52a52bf8
Reviewed-on: https://chromium-review.googlesource.com/1013269
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551755}
[modify] https://crrev.com/3262c9b296d995160b45d215803fe80f61fededb/testing/buildbot/chromium.win.json
[modify] https://crrev.com/3262c9b296d995160b45d215803fe80f61fededb/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)
This should be fixed now.

Sign in to add a comment