Bottom sheet needs to interact well with other bottom things |
||||||||
Issue descriptionThe bottom sheet needs to handle interaction with other UI that wants to show at the bottom of the screen. - Infobars - These have variable width depending on the screen size. - Snackbars - Overlay panels (contextual search) - Bottom toolbar I've attaches two videos of current interactions.
,
Mar 30 2018
Can you also capture a video of the first flow in split screen mode (non landscape)?
,
Apr 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b3fbb497146646cbc23317dafb522a7833f2db1 commit 1b3fbb497146646cbc23317dafb522a7833f2db1 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Apr 02 16:34:50 2018 Bottom container listens to bottom sheet The bottom container that hosts infobars and snackbars now listens to the bottom sheet. This allows the bottom container to stack on top of the sheet when it is showing. Bug: 827541 Change-Id: Ib130cf4149223afc892945f84483467b88c28588 Reviewed-on: https://chromium-review.googlesource.com/988063 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547446} [modify] https://crrev.com/1b3fbb497146646cbc23317dafb522a7833f2db1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/1b3fbb497146646cbc23317dafb522a7833f2db1/chrome/android/java/src/org/chromium/chrome/browser/snackbar/BottomContainer.java
,
Apr 4 2018
,
Apr 16 2018
Are the items we want for M67 done? If so, I'm thinking we should change the label to M-68?
,
Apr 20 2018
,
Apr 20 2018
,
Apr 20 2018
I think this is done for M68
,
Apr 23 2018
,
Apr 23 2018
+Austin as FYI
,
May 3 2018
What's left to do here?
,
May 3 2018
I think this is done. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by twelling...@chromium.org
, Mar 30 2018