New issue
Advanced search Search tips

Issue 827519 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 807640



Sign in to add a comment

Add test / verify behavior of subresource redirects for ad-tagging

Project Member Reported by csharrison@chromium.org, Mar 30 2018

Issue description

Case to check:
1. Resource a.com matches as an ad, due to initiator logic
2. a.com -> b.com redirect
3. Ensure final redirect request is tagged as an ad.

This is maybe WontFix, but I couldn't quite tell from the code.
 
Owner: csharrison@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db2ac2b4a172fcc15a9552bab343fcfe37cccf4

commit 2db2ac2b4a172fcc15a9552bab343fcfe37cccf4
Author: Charlie Harrison <csharrison@chromium.org>
Date: Fri Apr 06 01:59:18 2018

[ad-tagging] Persist IsAdResource across redirects

Bug:  827519 
Change-Id: I395dcad4993ecad65ecf7b55d76e7004fc919d3c
Reviewed-on: https://chromium-review.googlesource.com/987915
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548638}
[modify] https://crrev.com/2db2ac2b4a172fcc15a9552bab343fcfe37cccf4/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/2db2ac2b4a172fcc15a9552bab343fcfe37cccf4/third_party/WebKit/Source/platform/loader/fetch/ResourceRequestTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment