New issue
Advanced search Search tips

Issue 827510 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Apr 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Font size of the saved username appears smaller than the rest of the text on chrome://settings/passwords

Reported by vineetha...@etouch.net, Mar 30 2018 
Chrome Version: 67.0.3384.0 (Official Build) Revision 4274cfaab72400a5c8813141f18f457ce7d70640-refs/heads/master@{#547000}(64 bit)
OS: Mac(10.12.6, 10.13.1, 10.13.4) OS

What steps will reproduce the problem?
(1) Launch Chrome, navigate to www.gmail.com and Sign in with valid credentials.
(2) Click on Save button in the password bubble.
(3) Now navigate to chrome://settings/passwords and observe the font size of the saved username.

Actual Result: The font size of the saved username appears smaller than the rest of the text on the page.
Expected Result: All the text on the chrome://settings/passwords should have a uniform font size.

This is regression issue broken in ‘M-67’ and providing the bisect using per-revision bisect,
Good build: 67.0.3379.0(Revision: 545320)
Bad build: 67.0.3381.0(Revision: 545918)

You are probably looking for a change made after 545676 (known good), but no later than 545677 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/0e730cbd89e2f054b910d11481debcc826792e93..132ebcfe843381df99f3309260c3badff8520140

Suspect: https://chromium.googlesource.com/chromium/src/+/132ebcfe843381df99f3309260c3badff8520140

@hcarmona: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: This issue is not observed on Windows (7,8,8.1,10) & Linux(14.04 LTS) OS

Thank You!
ActualVideo.mov
3.9 MB View Download
ExpectedVideo.mov
3.4 MB View Download

Comment 1 by hcarmona@chromium.org, Mar 30 2018

Status: Started (was: Assigned)
Patch: https://crrev.com/c/988245
+Screenshot
password screenshot.png
70.7 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21318edd0725de4b5ed860c33f5e26ed9814d89d

commit 21318edd0725de4b5ed860c33f5e26ed9814d89d
Author: Hector Carmona <hcarmona@chromium.org>
Date: Wed Apr 04 21:32:29 2018

MD Settings: Fix username font styling in password page.

Bug:  827510 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a2f730de3ac0973c826672bfb9486e3630d7292
Reviewed-on: https://chromium-review.googlesource.com/988245
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548206}
[modify] https://crrev.com/21318edd0725de4b5ed860c33f5e26ed9814d89d/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html

Comment 3 by hcarmona@chromium.org, Apr 4 2018

Status: Fixed (was: Started)

Comment 4 by vineetha...@etouch.net, Apr 5 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3389.0
Update :
Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.4) OS with latest Canary Chrome version #67.0.3389.0 and the issue is fixed.

Kindly refer the attached screen cast.
FixedVideo.mov
2.9 MB View Download
►

Sign in to add a comment