New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827483 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Chrome OS S2S doesn't read text in edit text field of an Android app

Project Member Reported by yawano@chromium.org, Mar 30 2018

Issue description

Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Open any Android app which has an edit text field
(2) Type some text in the field
(3) Try to read it with Chrome OS S2S

What is the expected result?
S2S reads it.

What happens instead?
S2S doesn't read it.
 

Comment 1 by yawano@chromium.org, Mar 30 2018

Cc: f...@chromium.org
Owner: dtseng@chromium.org
dtseng@: I remember that you mentioned that this is caused because we simply set text as value of a node. Do you think adding a text value node under text field node is a good idea? We can fix S2S to check value of node. But I think it's better to align with how Chrome Automation API works on the web.

Comment 2 by yawano@chromium.org, Mar 30 2018

Components: UI>Accessibility>SelectToSpeak

Comment 3 by katie@chromium.org, Apr 2 2018

Owner: katie@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9a5267bc8ba3da69ee11fe71cf02eb43d91dd6f

commit d9a5267bc8ba3da69ee11fe71cf02eb43d91dd6f
Author: Katie D <katie@chromium.org>
Date: Tue Apr 10 18:45:47 2018

Select-to-Speak should read all textfield values if no name is present.

This fixes reading EditText contents in ARC++, as ARC++ EditTexts always
seem to have a value but no name.

Bug:  827483 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7ebbac7b38bb3ceb8d816471948cb487b518affe
Reviewed-on: https://chromium-review.googlesource.com/990433
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549602}
[modify] https://crrev.com/d9a5267bc8ba3da69ee11fe71cf02eb43d91dd6f/chrome/browser/resources/chromeos/select_to_speak/node_utils.js
[modify] https://crrev.com/d9a5267bc8ba3da69ee11fe71cf02eb43d91dd6f/chrome/browser/resources/chromeos/select_to_speak/node_utils_unittest.gtestjs
[modify] https://crrev.com/d9a5267bc8ba3da69ee11fe71cf02eb43d91dd6f/chrome/browser/resources/chromeos/select_to_speak/paragraph_utils.js
[modify] https://crrev.com/d9a5267bc8ba3da69ee11fe71cf02eb43d91dd6f/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js

Comment 5 by katie@chromium.org, Apr 12 2018

Status: Fixed (was: Started)

Sign in to add a comment