White splash doesn't look great with modern media controls |
||||||
Issue descriptionChrome Version : 67.0.3383.0 OS Version: 10527.0.0 What steps will reproduce the problem? 1. Enable Modern Media Control 2. Visit https://storage.googleapis.com/fbeaufort-test/sample-video.webm What is the expected result? The media loading UI should look great. What happens instead of that? A big white splash shows up and disrupts the viewing experience of user. See recording attached.
,
Mar 30 2018
Yes although I can't seem to find it :( If I remember correctly we should not show the spinner once the video has started playing.
,
Mar 31 2018
,
Apr 2 2018
,
Apr 3 2018
Could this bu a dup of bug 822018 ?
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bb7408267a06daa2fb6c9fdc445e36ce10242ca commit 5bb7408267a06daa2fb6c9fdc445e36ce10242ca Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Apr 03 19:33:07 2018 Media Controls: Hide loading panel on play If the media starts playing whilst the loading panel is either showing or cooling down we should hide it immediately as we are obscuring the video. BUG= 827482 Change-Id: Ie0fb8159469fcc6740f624d052ac4b176f4f6876 Reviewed-on: https://chromium-review.googlesource.com/990192 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#547791} [modify] https://crrev.com/5bb7408267a06daa2fb6c9fdc445e36ce10242ca/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElement.cpp [modify] https://crrev.com/5bb7408267a06daa2fb6c9fdc445e36ce10242ca/third_party/WebKit/Source/modules/media_controls/elements/MediaControlLoadingPanelElementTest.cpp
,
Apr 3 2018
,
Apr 5 2018
The white splash is actually a loading indicator although it should be showing the loading spinner whilst the page is loading.
,
Apr 5 2018
The white splash destroys usability of the player on dark-themed sites. The whitish default poster background color [1] displayed while the video is loading - is it really needed? Can't it be transparent? [1]: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css?l=601&rcl=4a4532d1fcc12e05f02486d8e8314220ce1947e3
,
Apr 5 2018
@woxxom - this is tracked in http://crbug.com/814727
,
Apr 5 2018
I did some more testing at it looks like the spinner not showing properly is limited to MediaDocument so I am going to file a separate bug that covers that.
,
Apr 6 2018
I'm not sure what you mean by limiting to MediaDocument but I can reproduce the white splash issue with this URL: data:text/html,<html><body style="background-color: rgb(0, 0, 0);"><video style="position: absolute; top: 0px; right: 0px; bottom: 0px; left: 0px; max-height: 100%; max-width: 100%; margin: auto;" controls="" autoplay="" name="media"><source src="https://storage.googleapis.com/fbeaufort-test/sample-video.webm" type="video/webm"></video></body></html>
,
Apr 6 2018
Okay I see the loading spinner before you click play which is white and semi-translucent. Is this what you are referring to? afaik this is part of the design (google.com required) - https://docs.google.com/presentation/d/1wso086QMuxxSyIJPuuv2T5aJOn3Mlwo4c9KhfAdMdGw/edit#slide=id.g25c04b0d98_0_7 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mlamouri@chromium.org
, Mar 30 2018