New issue
Advanced search Search tips

Issue 827432 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Split view indicators dont not work in RTL.

Project Member Reported by sammiequon@chromium.org, Mar 30 2018

Issue description

What steps will reproduce the problem?
(1) Use RTL.
(2) Enter overview.
(3) Drag a window to left edge.

What is the expected result?
Indicator should animate out and cover left half of screen.

What happens instead?
Indicator animates in and covers right half of screen.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36ab97fba01db6786a9b7973ddfd16fbf82e0101

commit 36ab97fba01db6786a9b7973ddfd16fbf82e0101
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Mar 30 18:09:20 2018

spltiview: Drag indicators work in RTL.

Also the left/top text label is now centered.
Also s/hightlight/highlight.

Test: manual
Bug:  827432 
Change-Id: Ieb0fac4563abb7b7c04973484d3cb2b0ef727868
Reviewed-on: https://chromium-review.googlesource.com/987302
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547207}
[modify] https://crrev.com/36ab97fba01db6786a9b7973ddfd16fbf82e0101/ash/wm/splitview/split_view_drag_indicators.cc

Status: Fixed (was: Assigned)

Sign in to add a comment