New issue
Advanced search Search tips

Issue 827430 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

ASSERT: appearance.HasFont()

Project Member Reported by ClusterFuzz, Mar 30 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5516349368172544

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  appearance.HasFont()
  CBA_FontMap::GetAnnotDefaultFont
  CBA_FontMap::Initialize
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=546646:546660

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5516349368172544

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 30 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 30 2018

Labels: Test-Predator-Auto-Owner
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/53a8093c6ef694ec520fe0b087fbac86af97f5e8 (Use CPDF_DefaultAppearance instead of custom parsing).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Blocking: 62400
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/4c22dd5690cdec725389055bb7c07c300a4b6fe4

commit 4c22dd5690cdec725389055bb7c07c300a4b6fe4
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Tue Apr 03 19:10:51 2018

Use Optional to determine if appearance stream as font

This CL changes the CPDF_DefaultAppearance code to remove the HasFont
method and change GetFont to return an Optional. This forces all the
call sites to verify a font was returned correctly and removes the need
for the duplicate appearance stream parsing.

Bug:  chromium:827430 
Change-Id: If09e0a7d3f7dd63ad77b97a5a388127e4a02da61
Reviewed-on: https://pdfium-review.googlesource.com/29610
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>

[modify] https://crrev.com/4c22dd5690cdec725389055bb7c07c300a4b6fe4/core/fpdfdoc/cpdf_formfield.cpp
[modify] https://crrev.com/4c22dd5690cdec725389055bb7c07c300a4b6fe4/core/fpdfdoc/cpvt_generateap.cpp
[modify] https://crrev.com/4c22dd5690cdec725389055bb7c07c300a4b6fe4/fpdfsdk/formfiller/cba_fontmap.cpp
[modify] https://crrev.com/4c22dd5690cdec725389055bb7c07c300a4b6fe4/core/fpdfdoc/cpdf_defaultappearance.cpp
[modify] https://crrev.com/4c22dd5690cdec725389055bb7c07c300a4b6fe4/core/fpdfdoc/cpdf_formcontrol.cpp
[modify] https://crrev.com/4c22dd5690cdec725389055bb7c07c300a4b6fe4/fpdfsdk/pwl/cpwl_appstream.cpp
[modify] https://crrev.com/4c22dd5690cdec725389055bb7c07c300a4b6fe4/core/fpdfdoc/cpdf_defaultappearance.h

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0478c840d112a17a800f174499b3043815442b18

commit 0478c840d112a17a800f174499b3043815442b18
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 03 22:29:02 2018

Roll src/third_party/pdfium/ 232b918d1..4c22dd569 (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/232b918d1f0f..4c22dd5690cd

$ git log 232b918d1..4c22dd569 --date=short --no-merges --format='%ad %ae %s'
2018-04-03 dsinclair Use Optional to determine if appearance stream as font

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:827430 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I30faeebc027568db41b6c9bf5e4d7240cec7dc0d
Reviewed-on: https://chromium-review.googlesource.com/993697
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547849}
[modify] https://crrev.com/0478c840d112a17a800f174499b3043815442b18/DEPS

Project Member

Comment 9 by ClusterFuzz, Apr 4 2018

ClusterFuzz has detected this issue as fixed in range 547840:547854.

Detailed report: https://clusterfuzz.com/testcase?key=5516349368172544

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  appearance.HasFont()
  CBA_FontMap::GetAnnotDefaultFont
  CBA_FontMap::Initialize
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=546646:546660
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=547840:547854

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5516349368172544

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Apr 4 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5516349368172544 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment