New issue
Advanced search Search tips

Issue 827428 link

Starred by 1 user
Status: Duplicate
Merged: issue 816677
Owner: ----
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Tabs no longer open at the end via extension

Reported by collin.c...@blueprairie.com, Mar 30 2018 
UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3381.1 Safari/537.36

Steps to reproduce the problem:
1. Install extension tabs2end (fdnmndmjohfdibaimhghhlblfnijdkac) or another that opens tabs via different index (ie. end of row)
2. Only as of 67.0.3381.1 this suddenly broke after working for ALL prior versions
3. Tabs now open at default index #

What is the expected behavior?
Honor the programmatic placement of tab index # from approved extension in Chrome store

What went wrong?
In essence it appears that any extension that programatically calls inline (background.html) of:

chrome.tabs.getAllInWindow(null,function(tabs){
            chrome.tabs.move(tabid,{index:tabs.length-1});

As an example worked for years only until 67.0.3381.1 (Official Build) dev (64-bit), at which time it no longer functions.

Did this work before? N/A 

Chrome version: 67.0.3381.1  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

As I also am a DEV please advise if something has changed as I cannot locate any new documentation to indicate this behavior should have changed at all in 67.0.3381.1 especially since this broke mid-v67 and not at v66 etc.

TIA!

Comment 1 by woxxom@gmail.com, Mar 30 2018 

Using https://chrome.google.com/webstore/detail/tabs2end/fdnmndmjohfdibaimhghhlblfnijdkac

Bisect info: 544631 (good) - 544634 (bad)
https://chromium.googlesource.com/chromium/src/+log/4ae41823..0832751d?pretty=fuller
Suspecting r544634 = 0832751d354f1ed576ee729d9a2a133c1f047dbf = https://crrev.com/c/953175 by rdevlin.cronin@chromium.org
"[Extensions] Remove manifest v1 handling in CSP"
Landed in 67.0.3378.0

This is an intended change, see  issue 816677 .
Your extension uses an outdated manifest version 1.
Quoting https://developer.chrome.com/extensions/manifest/manifest_version

    Consider manifest version 1 deprecated as of Chrome 18. 
    Version 2 is not yet required, but we will, at some point in the not-too-distant future, 
    stop supporting packages using deprecated manifest versions. 

You can see the corresponding error in console for the background page:

    Refused to execute inline script because it violates the following Content Security Policy directive: 
    "script-src 'self' blob: filesystem: chrome-extension-resource:". 
    Either the 'unsafe-inline' keyword, a hash ('sha256-8EOYNR5r62CjPmKgHOD9CcIvrUmxR4ewXrTfXPs1A3Q='),
    or a nonce ('nonce-...') is required to enable inline execution.

Comment 2 by viswa.karala@chromium.org, Mar 30 2018

Labels: Needs-Triage-M67

Comment 3 by collin.c...@blueprairie.com, Mar 30 2018 

Ahh okay I guess there is literally a universe between v18 and "someday we'll..." LOL.  I didn't even think of going that many years back in the docs.  Either way, at least a mention in release notes that this change did (or was going to) occur would have helped I hate seeing your time wasted replying to issues like this that were planned changes.

Thanks for replying so quickly!  That particular extension is not mine, but I'll certainly ensure any of mine that might still be using v1 are updated to v2!

Comment 4 by ajha@chromium.org, Mar 30 2018

Mergedinto: 816677
Status: Duplicate (was: Unconfirmed)
►

Sign in to add a comment