CCA: Change record button label to differentiate "start recording" and "stop recording" |
|||
Issue descriptionThis is a release blocking issue asked from the accessibility reviewer. Currently, the recording shutter button label is always "Record video". In accessibility mode, it reads "Record video, button, press search plus space to activate" for both start recording and stop recording cases. We should change the label to "Start recording" and "Stop recording", respectively. Yuli, can you prioritize on this? After this is fixed, please request the translation of strings.
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/apps/camera/+/c7b184cb6552fdcfe8fd10693884d7269edeb027 commit c7b184cb6552fdcfe8fd10693884d7269edeb027 Author: Yuli Huang <yuli@chromium.org> Date: Tue Apr 03 01:22:28 2018 Fix video recording's app/tooltip/error messages. BUG= chromium:827418 TEST=Tested manually on elm. Change-Id: I16531b982c88b80650140ca339748c0b88c38033 Reviewed-on: https://chromium-review.googlesource.com/988152 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/c7b184cb6552fdcfe8fd10693884d7269edeb027/src/js/views/camera.js [modify] https://crrev.com/c7b184cb6552fdcfe8fd10693884d7269edeb027/src/_locales/en/messages.json
,
Apr 3 2018
Please verify the fix after the canary is updated. Thanks.
,
Apr 9 2018
I can see the labels "Start recording" and "Stop recording" as tooltip messages. But, in accessibility Chromevox spoken feedback mode, it doesn't read out when clicked on 'Record video' button. It actually doesn't read out for any of the button press in camera app.
,
Apr 9 2018
After turning on accessibility mode, you have to use TAB to switch focus to different buttons. When the capture button in recording mode is focused, the tooltip of it will be read out.
,
May 11 2018
Verified on M67 (10575.32.0, 67.0.3396.41)
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c7b184cb6552fdcfe8fd10693884d7269edeb027 commit c7b184cb6552fdcfe8fd10693884d7269edeb027 Author: Yuli Huang <yuli@chromium.org> Date: Tue Apr 03 01:22:28 2018 Fix video recording's app/tooltip/error messages. BUG= chromium:827418 TEST=Tested manually on elm. Change-Id: I16531b982c88b80650140ca339748c0b88c38033 Reviewed-on: https://chromium-review.googlesource.com/988152 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Tested-by: yuli <yuli@chromium.org> [modify] https://crrev.com/c7b184cb6552fdcfe8fd10693884d7269edeb027/src/_locales/en/messages.json [modify] https://crrev.com/c7b184cb6552fdcfe8fd10693884d7269edeb027/src/js/views/camera.js |
|||
►
Sign in to add a comment |
|||
Comment 1 by shenghao@chromium.org
, Mar 30 2018