New issue
Advanced search Search tips

Issue 827415 link

Starred by 1 user
Status: Started
Owner:
hirosh...@chromium.org
Cc:
domfarolino@gmail.com
kouhei@chromium.org
domenic@chromium.org
neis@chromium.org
hirosh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 891052


Sign in to add a comment

Update spec links and comments (initially in core/script)

Project Member Reported by hirosh...@chromium.org, Mar 30 2018 
This issue tracks updating spec links and spec comments (e.g. of html.spec.whatwg.org) in the source code.

Note: this issue is comment update only.
Actual behavior changes for spec updates should be tracked separately, if any.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419

commit ff8bf3f3c07bc15a63c221cec150e85c4dc2d419
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Mar 30 08:31:03 2018

[Spec comment] Update links to HTML spec in core/script

Bug: 827415
Change-Id: I90b8953634d5092bedda4ccc427b5b75b5b0ae4f
Reviewed-on: https://chromium-review.googlesource.com/987205
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547131}
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ClassicPendingScript.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ClassicPendingScript.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/HTMLParserScriptRunner.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/Modulator.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ModulatorImplBase.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ModulatorTest.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ModuleImportMeta.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ModuleMap.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ModuleMap.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ModulePendingScript.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ModuleScript.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ModuleScript.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/PendingScript.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/README.md
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/Script.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ScriptLoader.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ScriptLoader.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ScriptModuleResolverImpl.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/ScriptModuleResolverImpl.h
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/XMLParserScriptRunner.cpp
[modify] https://crrev.com/ff8bf3f3c07bc15a63c221cec150e85c4dc2d419/third_party/WebKit/Source/core/script/XMLParserScriptRunner.h
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23b42c39fc9c7847e7b132800f44d0ea1734eba2

commit 23b42c39fc9c7847e7b132800f44d0ea1734eba2
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Wed Apr 11 05:01:01 2018

[Spec comment] Update/format some of HTML spec comments in core/script

Bug: 827415
Change-Id: I758c2332dbaa602bf09863317d83548a4e1367b8
Reviewed-on: https://chromium-review.googlesource.com/987390
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549768}
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/modulator.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/module_script.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/script_loader.h
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/script_module_resolver_impl.cc
[modify] https://crrev.com/23b42c39fc9c7847e7b132800f44d0ea1734eba2/third_party/blink/renderer/core/script/xml_parser_script_runner.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec1d034c261412ffce69b6cd7d49034ffd536e8b

commit ec1d034c261412ffce69b6cd7d49034ffd536e8b
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Apr 13 03:36:09 2018

[Spec comment] Use <spec> notations for HTML spec comments in core/script

Bug: 827415
Change-Id: Ia1d57357525366f1c07a6fd1d87b4f604072cb7a
Reviewed-on: https://chromium-review.googlesource.com/1000720
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550488}
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/modulator.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/module_script.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/script_loader.h
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/xml_parser_script_runner.cc

Comment 4 by domfarolino@gmail.com, Apr 16 2018 

I see the title of this indicates that this will only be for core/script right now. Is the plan to eventually roll this style of comments out to all spec comments?

Comment 5 by kouhei@chromium.org, Apr 16 2018 

We are starting from core/script, since hiroshige@ and I mainly contribute to it and we've been carefully maintaining the code to exactly match the spec.
We would love to extend this outside core/script, but I think we need further discussion before that.

Comment 6 by domfarolino@gmail.com, Apr 16 2018

Cc: domfarolino@gmail.com
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec1d034c261412ffce69b6cd7d49034ffd536e8b

commit ec1d034c261412ffce69b6cd7d49034ffd536e8b
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Fri Apr 13 03:36:09 2018

[Spec comment] Use <spec> notations for HTML spec comments in core/script

Bug: 827415
Change-Id: Ia1d57357525366f1c07a6fd1d87b4f604072cb7a
Reviewed-on: https://chromium-review.googlesource.com/1000720
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550488}
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/modulator.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/module_script.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/script_loader.h
[modify] https://crrev.com/ec1d034c261412ffce69b6cd7d49034ffd536e8b/third_party/blink/renderer/core/script/xml_parser_script_runner.cc

Comment 8 by hirosh...@chromium.org, Oct 1

Blockedon: 891052
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac76aa5a7a1b03629642cbc0082bb0705f721e7d

commit ac76aa5a7a1b03629642cbc0082bb0705f721e7d
Author: Hiroshige Hayashizaki <hiroshige@chromium.org>
Date: Tue Oct 16 15:52:18 2018

Format/update more spec comments in core/script

Bug: 827415
Change-Id: Ia2b38a57a7232dffaaa5f815b486baccbca92d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1274904
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599999}
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/classic_pending_script.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/dynamic_module_resolver.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/module_script.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/pending_script.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/script_module_resolver_impl.cc
[modify] https://crrev.com/ac76aa5a7a1b03629642cbc0082bb0705f721e7d/third_party/blink/renderer/core/script/xml_parser_script_runner.cc
►

Sign in to add a comment