[Autofill] Return .PreviouslyAccepted and .PreviouslyDenied UMA data to parent histograms |
||||
Issue descriptionContext: https://groups.google.com/a/google.com/forum/#!topic/chrome-autofill/62ALpkpdGXM In https://codereview.chromium.org/2839683002, the Autofill.CreditCardInfoBar.Server histogram was split into {Autofill.CreditCardInfoBar.Server, Autofill.CreditCardInfoBar.Server.PreviouslyDenied, Autofill.CreditCardInfoBar.Server.PreviouslyAccepted}. This caused confusion as it went against precedent where sub-histograms shouldn't affect their parent's data, and as a result hid a lot of data behind the .PreviouslyAccepted and .PreviouslyDenied subhistograms. In all, it affected these histograms: - Autofill.CreditCardInfoBar.Server - Autofill.CreditCardInfoBar.Local - Autofill.SaveCreditCardPrompt.Local.FirstShow - Autofill.SaveCreditCardPrompt.Local.Reshows - Autofill.SaveCreditCardPrompt.Upload.FirstShow - Autofill.SaveCreditCardPrompt.Upload.Reshows Here's what we want to happen instead, using Autofill.CreditCardInfoBar.Server as an example: 1) Autofill.CreditCardInfoBar.Server goes back to containing ALL data, not just a portion of it 2) What used to go to Autofill.CreditCardInfoBar.Server should now go to Autofill.CreditCardInfoBar.Server.UnknownPreviousDecision so that the subhistograms are still useful
,
Apr 2 2018
,
Apr 5 2018
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08cc92547dde67845cccefcef2dc7f9b1aaac828 commit 08cc92547dde67845cccefcef2dc7f9b1aaac828 Author: siyua <siyua@chromium.org> Date: Thu Apr 12 08:17:45 2018 Return .PreviouslyAccepted and .PreviouslyDenied data to parent histograms The Autofill.CreditCardInfoBar.Server histogram was split into { Autofill.CreditCardInfoBar.Server, Autofill.CreditCardInfoBar.Server.PreviouslyDenied, Autofill.CreditCardInfoBar.Server.PreviouslyAccepted}. This caused confusion as it went against precedent where sub-histograms shouldn't affect their parent's data, and as a result hid a lot of data behind the .PreviouslyAccepted and .PreviouslyDenied subhistograms. Here's what we want to happen instead, using Autofill.CreditCardInfoBar.Server as an example: 1) Autofill.CreditCardInfoBar.Server goes back to containing ALL data, not just a portion of it. 2) What used to go to Autofill.CreditCardInfoBar.Server should now go to Autofill.CreditCardInfoBar.Server.NoPreviousDecision so that the subhistograms are still useful. Bug: 827414 Change-Id: I432e98f4729318e3e060e280551286b2bcfb80b0 Reviewed-on: https://chromium-review.googlesource.com/997026 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#550100} [modify] https://crrev.com/08cc92547dde67845cccefcef2dc7f9b1aaac828/chrome/browser/autofill/autofill_save_card_infobar_delegate_mobile_unittest.cc [modify] https://crrev.com/08cc92547dde67845cccefcef2dc7f9b1aaac828/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc [modify] https://crrev.com/08cc92547dde67845cccefcef2dc7f9b1aaac828/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/08cc92547dde67845cccefcef2dc7f9b1aaac828/tools/metrics/histograms/histograms.xml
,
Apr 19 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jiahuiguo@chromium.org
, Mar 30 2018