New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 827385 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Refactor out FlakeSwarmingTaskOutput from pipeline

Project Member Reported by lijeffrey@chromium.org, Mar 29 2018

Issue description

To make RunFlakeSwarmingTaskPipeline asynchronous, the output will move to services. Thus it is better to have the output type in a dto rather than defined within the pipeline
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6086ce365cef6711e6c60c76b68e2b857c9a361b

commit 6086ce365cef6711e6c60c76b68e2b857c9a361b
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Mar 29 23:58:02 2018

[Findit] Flake Analyzer - Separating FlakeSwarmingTaskOutput from pipeline

No functional change. Renaming RunFlakeSwarmingTaskOutput -> FlakeSwarmingTaskOutput
and defining it under dto/ rather than within the pipeline. This will be necessary
with the redefining of RunFlakeSwarmingTaskPipeline as an asynchronous rather than
generator pipeline, as service modules will be responsible for crafting instances of
FlakeSwarmingTaskOutput.

Bug:  827385 
Change-Id: Iabb600fbe9c7f16cf669af3550b3715e12af9f9a
Reviewed-on: https://chromium-review.googlesource.com/987095
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[add] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/dto/flake_swarming_task_output.py
[add] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/dto/test/flake_swarming_task_output_test.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/pipelines/flake_failure/update_flake_analysis_data_points_pipeline.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/pipelines/flake_failure/test/update_flake_analysis_data_points_pipeline_test.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/pipelines/flake_failure/run_flake_swarming_task_pipeline.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/services/flake_failure/test/flake_analysis_util_test.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/services/flake_failure/test/pass_rate_util_test.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/services/flake_failure/test/data_point_util_test.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/pipelines/flake_failure/determine_approximate_pass_rate_pipeline.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/pipelines/flake_failure/test/run_flake_swarming_task_pipeline_test.py
[modify] https://crrev.com/6086ce365cef6711e6c60c76b68e2b857c9a361b/appengine/findit/pipelines/flake_failure/test/determine_approximate_pass_rate_pipeline_test.py

Status: Verified (was: Assigned)

Sign in to add a comment